Skip to content

test: Chapter 4 & 5 practice submissions with validation tests#69

Open
accesswatch wants to merge 3 commits intomainfrom
test/beginner-challenge-1
Open

test: Chapter 4 & 5 practice submissions with validation tests#69
accesswatch wants to merge 3 commits intomainfrom
test/beginner-challenge-1

Conversation

@accesswatch
Copy link
Collaborator

@accesswatch accesswatch commented Mar 6, 2026

Test PR for Automation Workflows

This PR tests the learning-room automation system with practice submissions for Chapter 4 and Chapter 5 challenges.

Closes #1 (test issue reference)

Files Added

  • \practice/chapter-4-1-create-issue.md\ - Chapter 4 practice
  • \practice/chapter-5-2-linked-pr.md\ - Chapter 5 practice with intentional issues

Intentional Validation Test Cases

This PR includes controlled validation issues to test bot responses:

  • ❌ Broken relative link to
    onexistent-file.md\
  • ❌ Missing alt text on image
  • ❌ Vague link text: 'click here' and 'read more'

Expected Workflow Responses

  1. pr-validation-bot (within 30s): Validates PR structure, checks issue reference
  2. content-validation (within 30s): Reports all 3 validation issues with fix guidance
  3. skills-progression (on merge): Awards achievement badge

Test Status: ⏳ Awaiting workflow execution
Monitor: Check Actions tab and PR comments below

@accesswatch
test: Chapter 4 and 5 practice submissions
7faa430 
This commit contains test submissions for:
- Chapter 4.1: Create issue practice (Closes #1)
- Chapter 5.2: Linked PR practice

Intentional validation test cases:
- Broken relative link to nonexistent-file.md
- Missing alt text on screenshot image
- Vague link text 'click here' and 'read more'

Expected workflow responses:
- pr-validation-bot: validates PR structure and issue link
- content-validation: catches 3 accessibility/content issues
- Provides fix guidance for each issue
Copilot AI review requested due to automatic review settings March 6, 2026 01:53
@github-actions
Copy link

github-actions bot commented Mar 6, 2026

Welcome to Your First Pull Request! 🎉

Hi @accesswatch! Congratulations on opening your first PR in the Learning Room!

What Happens Next

  1. Automated Checks — This bot validates your PR within ~30 seconds
  2. Review Feedback — You'll see a validation report below
  3. Peer Review — A facilitator or peer will review your changes
  4. Iterate — Make updates if needed based on feedback
  5. Merge — Once approved, your changes are merged!

While You Wait

  • ✅ Check the automated validation report below
  • 📖 Review the PR Guidelines
  • 👀 Look at other open PRs to learn from examples
  • 💬 Ask questions in comments - no question is too basic!

Remember: Every experienced open source contributor started exactly where you are now.
Your perspective and effort matter!

This is an automated message from the Learning Room Bot.

@github-actions
Copy link

github-actions bot commented Mar 6, 2026 •
edited
Loading

PR Validation Report

✅ Validation Passed

✓ Required Checks

✅ Issue Reference

✅ PR Description

📚 Learning Resources

Based on your changes, these guides might help:

Automated validation by Learning Room Bot. Last updated: 2026-03-06T01:57:01.129Z
Questions? Check the guides or mention @Facilitator in a comment.

@accesswatch
fix: add package-lock.json for npm ci in workflows
4392d1a 
npm ci requires package-lock.json for reproducible builds in GitHub Actions.
This fixes the workflow installation error.
Copilot AI reviewed Mar 6, 2026
View reviewed changes
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adds practice submission markdown files for Chapter 4 and Chapter 5, intended to exercise the repository’s automation/validation workflows (issue linking, link validation, and accessibility checks).

Changes:

  • Added Chapter 4 practice submission markdown (practice/chapter-4-1-create-issue.md)
  • Added Chapter 5 practice submission markdown (practice/chapter-5-2-linked-pr.md) containing validation-test cases (broken links / non-descriptive link text)

Reviewed changes

Copilot reviewed 2 out of 3 changed files in this pull request and generated 5 comments.

File Description
practice/chapter-4-1-create-issue.md Adds Chapter 4 practice submission content.
practice/chapter-5-2-linked-pr.md Adds Chapter 5 linked-PR submission content, including links/images used for validation testing.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

practice/chapter-5-2-linked-pr.md

![Project screenshot](./screenshot.png)

You can [read more](https://example.com) about pull requests in the GitHub docs.
Copy link

Copilot AI Mar 6, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The link text "read more" is non-descriptive and is flagged by the repo’s accessibility checker. Use specific link text that describes what the reader will get at the destination.

Suggested change
You can [read more](https://example.com) about pull requests in the GitHub docs.
You can [read more about pull requests in the GitHub docs](https://example.com).

Copilot uses AI. Check for mistakes.
practice/chapter-5-2-linked-pr.md

## Notes

For more information about GitHub workflow, [click here](./nonexistent-file.md).
Copy link

Copilot AI Mar 6, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This relative link points to a file that doesn't exist in the repo, so link validation will fail. Update it to an existing document path (or add the referenced file if it’s intended to exist).

Suggested change
For more information about GitHub workflow, [click here](./nonexistent-file.md).
For more information about GitHub workflow, [click here](https://docs.github.com/en/get-started/quickstart/github-flow).

Copilot uses AI. Check for mistakes.
practice/chapter-5-2-linked-pr.md

## Notes

For more information about GitHub workflow, [click here](./nonexistent-file.md).
Copy link

Copilot AI Mar 6, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The link text "click here" is non-descriptive and is flagged by the repo’s accessibility checker. Replace it with meaningful text that indicates the destination (e.g., the name of the doc being linked).

Suggested change
For more information about GitHub workflow, [click here](./nonexistent-file.md).
For more information about GitHub workflow, see the [GitHub workflow documentation](./nonexistent-file.md).

Copilot uses AI. Check for mistakes.
practice/chapter-5-2-linked-pr.md

For more information about GitHub workflow, [click here](./nonexistent-file.md).

![Project screenshot](./screenshot.png)
Copy link

Copilot AI Mar 6, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This image references ./screenshot.png, but there is no screenshot.png file in the repository, so link validation will fail. Add the image asset at that path or update the link to an existing image.

Suggested change
![Project screenshot](./screenshot.png)
![Project screenshot](https://via.placeholder.com/800x600?text=Project+Screenshot)

Copilot uses AI. Check for mistakes.
practice/chapter-5-2-linked-pr.md

For more information about GitHub workflow, [click here](./nonexistent-file.md).

![Project screenshot](./screenshot.png)
Copy link

Copilot AI Mar 6, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR description says there is a “missing alt text on image” validation case, but the image here already has alt text ("Project screenshot"), so that specific check will not fail. Either update the PR description to match reality, or adjust the markdown if you intended to test the missing-alt-text validator.

Copilot uses AI. Check for mistakes.
@accesswatch
fix: add permissions to content-validation workflow
0e9781c 
Add pull-requests: write and issues: write permissions to allow
the workflow to post validation feedback comments on PRs.

Fixes 403 'Resource not accessible by integration' error.
@github-actions
Copy link

github-actions bot commented Mar 6, 2026

📋 Content Validation Report

♿ Accessibility

  • Non-Descriptive Link Text (practice/chapter-5-2-linked-pr.md Line 22)
    Link text "Click here" doesn't describe where the link goes.
    Fix: Replace "Click here" with descriptive text like "Topic Name"

  • Non-Descriptive Link Text (practice/chapter-5-2-linked-pr.md Line 26)
    Link text "Read more" doesn't describe where the link goes.
    Fix: Replace "Read more" with descriptive text like "Topic Name"

📚 Learning Resources

Automated validation by Learning Room. Questions? Check the guides or mention @Facilitator.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Copilot left review comments

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

first-time-contributor needs-review

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Assignment 01] Fix Broken Link in Welcome Guide - @accesswatch

2 participants

@accesswatch