Skip to content

test: Chapter 4 & 5 practice submissions with validation tests #69

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
accesswatch wants to merge 3 commits into
base: main
Choose a base branch
from
Open

test: Chapter 4 & 5 practice submissions with validation tests #69

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
7faa430
test: Chapter 4 and 5 practice submissions
accesswatch Mar 6, 2026
4392d1a
fix: add package-lock.json for npm ci in workflows
accesswatch Mar 6, 2026
0e9781c
fix: add permissions to content-validation workflow
accesswatch Mar 6, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .github/workflows/content-validation.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,11 @@ on:
pull_request:
types: [opened, edited, synchronize, reopened]

permissions:
contents: read
pull-requests: write
issues: write

jobs:
validate-content:
runs-on: ubuntu-latest
Expand Down
16 changes: 16 additions & 0 deletions package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

33 changes: 33 additions & 0 deletions practice/chapter-4-1-create-issue.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,33 @@
# Chapter 4.1: Create Your First Issue - Test Submission

**Student:** Test User (@testuser)
**Challenge:** Chapter 4 - Working with Issues
**Task:** Create one issue with a clear title and short description

## What I Learned

I learned how to create an issue on GitHub with:
- A clear, descriptive title
- A concise description of what needs to be done
- Proper formatting using markdown

## My Practice Issue

I created issue #1 requesting to add a new feature to the learning room documentation.

The issue includes:
- Title: "Add keyboard shortcuts guide"
- Description: Brief explanation of what's needed
- Labels: documentation, enhancement

## Reflection

Creating issues helps organize work and communicate clearly with team members. Good issue titles make it easier for everyone to understand what needs attention.

---

**Completion checklist:**
- [x] Issue created with clear title
- [x] Description provided
- [x] Issue linked in this document
- [x] Reflection written
26 changes: 26 additions & 0 deletions practice/chapter-5-2-linked-pr.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,26 @@
# Chapter 5.2: Open a Linked PR - Test Submission

This PR demonstrates linking to an issue using the Closes keyword.

## What Changed

Added documentation about creating issues in Chapter 4.

## Issue Reference

Closes #1

## Testing Checklist

- [x] Branch created from main
- [x] Changes committed with clear message
- [x] PR linked to issue using "Closes #XX"
- [x] PR description includes what changed

## Notes

For more information about GitHub workflow, [click here](./nonexistent-file.md).
Copy link

Copilot AI Mar 6, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This relative link points to a file that doesn't exist in the repo, so link validation will fail. Update it to an existing document path (or add the referenced file if it’s intended to exist).

Suggested change
For more information about GitHub workflow, [click here](./nonexistent-file.md).
For more information about GitHub workflow, [click here](https://docs.github.com/en/get-started/quickstart/github-flow).

Copilot uses AI. Check for mistakes.
Copy link

Copilot AI Mar 6, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The link text "click here" is non-descriptive and is flagged by the repo’s accessibility checker. Replace it with meaningful text that indicates the destination (e.g., the name of the doc being linked).

Suggested change
For more information about GitHub workflow, [click here](./nonexistent-file.md).
For more information about GitHub workflow, see the [GitHub workflow documentation](./nonexistent-file.md).

Copilot uses AI. Check for mistakes.

![Project screenshot](./screenshot.png)
Copy link

Copilot AI Mar 6, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This image references ./screenshot.png, but there is no screenshot.png file in the repository, so link validation will fail. Add the image asset at that path or update the link to an existing image.

Suggested change
![Project screenshot](./screenshot.png)
![Project screenshot](https://via.placeholder.com/800x600?text=Project+Screenshot)

Copilot uses AI. Check for mistakes.
Copy link

Copilot AI Mar 6, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR description says there is a “missing alt text on image” validation case, but the image here already has alt text ("Project screenshot"), so that specific check will not fail. Either update the PR description to match reality, or adjust the markdown if you intended to test the missing-alt-text validator.

Copilot uses AI. Check for mistakes.

You can [read more](https://example.com) about pull requests in the GitHub docs.
Copy link

Copilot AI Mar 6, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The link text "read more" is non-descriptive and is flagged by the repo’s accessibility checker. Use specific link text that describes what the reader will get at the destination.

Suggested change
You can [read more](https://example.com) about pull requests in the GitHub docs.
You can [read more about pull requests in the GitHub docs](https://example.com).

Copilot uses AI. Check for mistakes.