Repository navigation
chore(openspec): tick the timetable course query's live check, which passed - #867
Merged
rubenvdlinde merged 1 commit intoOct 4, 2026
Merged
Conversation
…passed Task 2.1 of timetable-course-query: two planninq lessons with a courseId reached learniq's elective picker, which warned about the overlap, and the lesson with an https onlineMeetingUrl showed Join in My timetable, opening a new tab. Verified on the shared instance on 3 Oct 2026. Every task is now ticked. The archive stays with the planninq lane: three @SPEC tags in lib/ and one in tests/ still point at the change's path.
Contributor
Quality Report — ConductionNL/planninq @
|
| Check | PHP | Vue | Security | License | Tests |
|---|---|---|---|---|---|
| lint | ✅ | ||||
| phpcs | ✅ | ||||
| phpmd | ✅ | ||||
| psalm | ✅ | ||||
| phpstan | ✅ | ||||
| phpmetrics | ✅ | ||||
| eslint | ✅ | ||||
| stylelint | ✅ | ||||
| build | ✅ | ||||
| check-manifest | ✅ | ||||
| check-l10n-js | ✅ | ||||
| check-schema-l10n | ✅ | ||||
| composer | ✅ | ✅ 107/107 | |||
| npm | ✅ | ✅ 646/646 | |||
| app:check-code | ⏭️ | ||||
| info.xml | ✅ | ||||
| REUSE | ❌ | ||||
| lockfile sync | ✅ | ||||
| PHPUnit | ⏭️ not run for this diff — no file in this diff matches the code globs, and none carries a source extension — the heavy tier has nothing to decide about it. | ||||
| Newman | ❌ | ||||
| Playwright | ⏭️ deferred: E2E runs locally and on the promotion path only. This pull request targets development, so the suite is asked once per promotion into beta and main rather than once per push per open pull request. Run it locally with npx playwright test, or from the Actions tab on a branch with no open pull request into development. |
||||
| Hydra gates | ✅ |
Quality workflow — 2026-10-03 09:13 UTC
Download the full PDF report from the workflow artifacts.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ticks task 2.1 of
timetable-course-query. Openspec only, one line.Live check on the shared instance, 3 Oct 2026 (planninq e20f551, learniq 41e54a90):
GET /apps/learniq/api/timetable/course-slots?courseIds=<A>,<B>&withCore=1returned 200 with both courses in the same slot (before this change, both were empty).Every task in the change is now ticked. The archive is left to the planninq lane, because three
@spectags in lib/ and one in tests/ still point atopenspec/changes/timetable-course-query/and need moving in the same PR.