Skip to content

chore(openspec): tick the timetable course query's live check, which passed #867

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rubenvdlinde merged 1 commit into from
Oct 4, 2026
Merged

chore(openspec): tick the timetable course query's live check, which passed #867

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion openspec/changes/timetable-course-query/tasks.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,4 +8,4 @@

## 2. Live check (with learniq)

- [ ] 2.1 After learniq's `fix/planninq-course-sessions-and-link` lands: set `courseId` on two overlapping planninq lessons for two elective courses; `GET /apps/learniq/api/timetable/course-slots?courseIds=<A>,<B>&withCore=1` as a learner answers both slots and the picker warns; set an https `onlineMeetingUrl` on a lesson and My timetable shows Join, opening in a new tab. learniq refreshes its stub of the event class (`tests/Stubs/Planninq/Event/TimetableSessionsQueryEvent.php`) when this lands.
- [x] 2.1 After learniq's `fix/planninq-course-sessions-and-link` lands: set `courseId` on two overlapping planninq lessons for two elective courses; `GET /apps/learniq/api/timetable/course-slots?courseIds=<A>,<B>&withCore=1` as a learner answers both slots and the picker warns; set an https `onlineMeetingUrl` on a lesson and My timetable shows Join, opening in a new tab. learniq refreshes its stub of the event class (`tests/Stubs/Planninq/Event/TimetableSessionsQueryEvent.php`) when this lands. Verified live 3 Oct 2026 on the shared instance (planninq e20f5517, learniq 41e54a90): two lessons for courses LP-A and LP-B on Tuesday 10:00-10:50Z, `course-slots` as lp-learner answered both in the same slot, the picker warned "Live pass safety basics and Live pass advanced tooling meet at the same time: Tuesday 12:00–12:50.", and My timetable showed Join on the lesson with an https link, opening a new tab (build-all livepass/RESULT-lane5.md, "learniq D8").
Loading