Repository navigation
feat(token-sets): Zuiddrecht gets a light website hero and a blue piece under the current menu item - #1099
Merged
Conversation
…ce under the current menu item Six tokens for the Zuiddrecht set on a portal: a light hero ground with dark type (14.88:1) and the grey emblem as its watermark, and the current menu item drawn as a blue piece of the red line under the menu. The dark variant is regenerated from the set.
Contributor
Quality Report — ConductionNL/thematiq @
|
| Check | PHP | Vue | Security | License | Tests |
|---|---|---|---|---|---|
| lint | ✅ | ||||
| phpcs | ✅ | ||||
| phpmd | ✅ | ||||
| psalm | ✅ | ||||
| phpstan | ✅ | ||||
| phpmetrics | ✅ | ||||
| eslint | ✅ | ||||
| stylelint | ✅ | ||||
| build | ✅ | ||||
| check-manifest | ✅ | ||||
| test-l10n | ✅ | ||||
| format | ✅ | ||||
| test-fonts | ✅ | ||||
| test-token-set-coverage | ✅ | ||||
| composer | ✅ | ✅ 107/107 | |||
| npm | ✅ | ✅ 2/2 | |||
| app:check-code | ⏭️ | ||||
| info.xml | ✅ | ||||
| REUSE | ✅ | ||||
| lockfile sync | ✅ | ||||
| PHPUnit | ❌ | ||||
| Newman | ✅ | ||||
| Playwright | ⏭️ deferred: E2E runs locally and on the promotion path only. This pull request targets development, so the suite is asked once per promotion into beta and main rather than once per push per open pull request. Run it locally with npx playwright test, or from the Actions tab on a branch with no open pull request into development. |
||||
| Hydra gates | ✅ |
Quality workflow — 2026-10-05 18:03 UTC
Download the full PDF report from the workflow artifacts.
rubenvdlinde
added a commit
that referenced
this pull request
Oct 6, 2026
…fresh its reference page (#1105) #1099 gave Zuiddrecht --nldesign-website-nav-current-in-line and --nldesign-website-nav-current-color, but no stylesheet in thematiq (or the portal) reads either name, so TokenSetVocabularyTest failed on every PHPUnit leg, and the committed reference page still listed 82 tokens instead of the set's current ones. Removing the two unread names changes nothing on screen. The dark variant is regenerated from the set, and docs/reference/token-sets/zuiddrecht.md from composer docs:token-reference, so it now also lists the hero tokens from #1099 that public-bridge.css does read. Co-authored-by: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Co-authored-by: Ruben van der Linde <ruben@conduction.nl>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes
Six tokens in the Zuiddrecht set, for its website in portaliq (portaliq #1206):
--nldesign-website-nav-current-in-lineand--nldesign-website-nav-current-colorfor this; a set that does not name them keeps today's marker.css/tokens/dark/zuiddrecht.cssis regenerated from the set.Verified
stylelint,lint,test:guest-css,test:component-scopes,test:theme-scopes,test:internal-scopes,test:token-set-coverage,test:inventory: exit 0.vitest run: result in the first comment if it differs from green; the workplace layout spec passes (18 of 18).prettier --check: clean on the two files; the local run flags only untracked files under.lane-logs/.Not seen in a browser on a real instance yet: portaliq #1206, which draws this, is not merged.
Known, inherited
The dark variant gives the hero near-black type on a dark ground (
--nldesign-hero-title-color: #111111on#13202e). The generator does the same for the school sets with a light hero (for exampleesdoornveen). The portal site loads no dark layer today, so nothing shows it, but the pair is wrong and is filed as a separate issue.🤖 Generated with Claude Code