fix(listener): improve Discord delivery failure logging - #670
Merged
Abd-Standard merged 1 commit intoSep 1, 2026
Merged
Conversation
|
@praizeD10 Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
- Replace duplicate success log with a single, richer delivery log - Add classifyHttpStatus() to map status codes to readable categories (rate_limited, auth_error, not_found, client_error, server_error) - Add safeReadResponseBody() to capture error bodies with 300-char cap - Surface retryAfter header on 429 responses for actionable diagnostics - Pass logContext through sendWebhook() so timeout logs carry requestId and eventId for end-to-end traceability - Fix sendTestMessage() to log error detail on non-ok responses instead of a bare ok:true/false field - Webhook URL and tokens never appear in any log path; only webhookId is logged - Update e2e test assertions to match renamed log messages and new field names (httpStatus, httpCategory) in both delivery lifecycle and multi-channel test suites
praizeD10
force-pushed
the
feature/improve-discord-delivery-logging
branch
from
August 30, 2026 12:26
5bc550e to
6562c08
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
Related Issue
Closes #638
Changes
Verification
How to Test
Checklist
maincargo fmt --allrun (if Rust changes)npm run lintpasses (if TypeScript changes)