AI: sea transports for land units across water

[CubeB]

AiSideUnits knows only airTransport, and TransportManager assumes an aircraft throughout.

There is no original to copy: §103 could not establish that TA's computer player uses transports at all. What there is are constraints. A sea or hover transport refuses anything with a positive minwaterdepth, so this is only ever about moving land units across water. Loading is always an order to the transport, never to the passenger (§103).

Where to look: src/rwe/ai/TransportManager.*, AiSideUnits, and ReachabilityMap for which land a kbot can walk to.

Watch for: the AI runs inside the deterministic sim (CLAUDE.md), so no unordered iteration and no std::uniform_int_distribution.

Done when: on an island map without air transports, the AI ferries land units across by sea, with an AI test.

---

One item, one PR. Opened from the unchecked Phase 1 list in docs/ROADMAP.md; the findings it cites are in docs/TOTALA-EXE.md.

[CubeB]

Implemented and tested in 130bcf32. Leaving this open until it has been play-tested — the acceptance criterion below is met by a passing test, but nothing here has been watched in a running game yet.

The acceptance criterion, met: TransportManager.test.cpp has "a sea transport ferries the army across water it cannot walk", on a channel map with no air transport defined at all, so resolveAiSideUnits leaves airTransport empty and there is nothing that flies to lean on. Land units are booked onto an ARMTSHIP and carried across. A second section pins that a passenger needing water is never booked.

What it took. The simulation side turned out to be done already: it refuses a non-flying transport any passenger with a positive minWaterDepth, and it parses and models transportCapacity/transportSize. The gap was entirely AI-side, which makes this a smaller change than the roadmap implied.

• AiSideUnits gained the naval roles, including seaTransport (ARMTSHIP/CORTSHIP).
• TransportManager gained a hull counterpart to landingNear. A ship cannot come ashore anywhere along the way, so its drop point needs naval-reachable water beside it, not merely dry ground the cargo can walk on — landingNear's straight-line walk to the first dry tile is right for something that flies and useless for a hull.
• ReachabilityMap carries a second, naval labelling so "can this hull get there" is answerable at all, and AiPlayerController rebuilds it on the ground layer's cadence, skipping it entirely where there is no navigable water or no floating hull.
• The passenger filter now mirrors the simulation's water rule, so the AI stops booking passengers the sim then declines.

Three pre-existing bugs fell out of this, all now fixed.

1. One UnloadOrder sets down one unit. This issue's own note said so, quoting the constraint, and nothing had acted on it. handleUnloadOrder returns after a single unit in both branches and says as much in its own comment, while TransportManager was issuing N load commands and a single unload — in three separate places. Every passenger after the first was stranded aboard. This affected air ferries too; it hid because the only pinned ferry test uses a real ARMATLAS, which the simulation caps at one passenger anyway.
2. An air transport carries exactly one, whatever its FBI says. The original's VTOL pickup aborts while anything is attached, which is why the Atlas's transportcapacity=5 never meant five. The AI used the FBI figure and booked passengers the sim refused, leaving them marked as ferry passengers — out of the army, waiting for a lift that never came.
3. The size gate tested the wrong field. canLoadUnitIntoTransport gates on the passenger's footprint X against transportsize; the AI compared the passenger's own transportSize, which is 0 for anything that is not itself a transport, so the gate passed everything.

All three are the same shape: the AI booking a passenger the simulation declines.

One thing deliberately left open. armySize counts combatUnits only, and warships are now classified separately, so a force that is mostly ships may never reach the Attack phase — which is what gates the army ferry. Ships still fight, because the naval tactics pass does not depend on the phase. Fixing it is a real design choice (count hulls toward the army, and the AI attacks on land because it has boats; or give the phase machine a naval trigger of its own) and is not made here.

Still owed before this closes: a play-test on a real island map, and an arena A/B run against navalFleetSize=0 to show the navy is worth its metal rather than merely present.

🤖 Generated with Claude Code

https://claude.ai/code/session_018moxVoyHDBoHqkw8uqS3HX