🛡️ Sentinel: [MEDIUM] Add Referrer-Policy security header - #273
dieterolson wants to merge 2 commits into
Conversation
Added `Referrer-Policy: no-referrer` to the FastAPI application's security headers middleware to prevent leakage of sensitive local URLs or state to external domains. Co-authored-by: dieterolson <198168927+dieterolson@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: ce570eaa95
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| response.headers["Strict-Transport-Security"] = ( | ||
| "max-age=31536000; includeSubDomains" | ||
| ) | ||
| response.headers["Referrer-Policy"] = "no-referrer" |
There was a problem hiding this comment.
The commit adds a new response-header contract but changes no test to assert Referrer-Policy: no-referrer; as a result, later middleware reordering or removal could silently undo the intended protection while the current API suite remains green. Add a request-level regression test covering this header as required by the repository's test-first policy.
AGENTS.md reference: AGENTS.md:L175-L177
Useful? React with 👍 / 👎.
| response.headers["Strict-Transport-Security"] = ( | ||
| "max-age=31536000; includeSubDomains" | ||
| ) | ||
| response.headers["Referrer-Policy"] = "no-referrer" |
There was a problem hiding this comment.
This implementation commit neither adds nor updates the canonical handoff, leaving its changed files, validation evidence, and continuation state unavailable to the next agent. The Sentinel note is not a substitute for the required same-commit handoff update; create or refresh the canonical handoff, or record the prescribed no-material-change entry.
AGENTS.md reference: AGENTS.md:L271-L275
Useful? React with 👍 / 👎.
| response.headers["Strict-Transport-Security"] = ( | ||
| "max-age=31536000; includeSubDomains" | ||
| ) | ||
| response.headers["Referrer-Policy"] = "no-referrer" |
There was a problem hiding this comment.
The commit changes src/bitnet_launcher/api.py, but the canonical development log has no live entry for this security-header work, governing issue, or branch. That makes the implementation orphaned from the repository's state tracking; add or update the issue-keyed entry in the same change.
AGENTS.md reference: AGENTS.md:L336-L341
Useful? React with 👍 / 👎.
Added `Referrer-Policy: no-referrer` to the FastAPI application's security headers middleware to prevent leakage of sensitive local URLs or state to external domains. Co-authored-by: dieterolson <198168927+dieterolson@users.noreply.github.com>
1 participant
🚨 Severity: MEDIUM
💡 Vulnerability: The local FastAPI server lacked a
Referrer-Policyheader, potentially allowing sensitive local application URLs or state to leak to external domains via theRefererheader when making outbound requests.🎯 Impact: Minor information exposure regarding local development environments or sensitive paths.
🔧 Fix: Explicitly set
Referrer-Policy: no-referrerin theadd_security_headersmiddleware.✅ Verification: Ran unit tests and verified linting passes.
PR created automatically by Jules for task 14293462493016191517 started by @dieterolson