ci: fix local-only-runner-guard.yml failing to parse on every push - #57
Conversation
…kflow parses
GitHub evaluates ${{ }} inside run: blocks; the literal `${{ ... }}` in the
embedded Python docstring is an invalid expression, so the whole workflow
failed to process on every push (0 jobs, name shown as the file path).
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Signed-off-by: Dieter Olson <dieterolson@gmail.com>
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 08f5be4763
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
|
||
| def expression_candidates(value: str) -> list[str]: | ||
| """Return every runner label a `${{ ... }}` expression could resolve to. | ||
| """Return every runner label an Actions expression could resolve to. |
There was a problem hiding this comment.
This implementation commit changes CI behavior but only modifies the workflow, leaving the required canonical handoff unupdated. Since this repository currently has no docs/development/HANDOFF.md, the continuation state for the change remains undocumented; add the canonical handoff update in the same commit as required.
AGENTS.md reference: AGENTS.md:L158-L163
Useful? React with 👍 / 👎.
| # Reduce every runs-on to the concrete set of labels it can | ||
| # actually produce: dereference needs.<job>.outputs.<x> through | ||
| # the producing job, and expand a `${{ ... }}` toggle into each | ||
| # the producing job, and expand an Actions-expression toggle into each |
There was a problem hiding this comment.
This implementation change does not update docs/development/DEVELOPMENT_LOG.md. Even if this small CI repair does not warrant a material entry update, the repository's explicit escape hatch requires staging the log with No material development-log change — <reason> rather than omitting it.
AGENTS.md reference: AGENTS.md:L250-L252
Useful? React with 👍 / 👎.
1 participant
Why was this required?
The embedded Python docstring/comments in
.github/workflows/local-only-runner-guard.ymlcontain a literal${{ ... }}. GitHub evaluates${{ }}insiderun:blocks,...is an invalid expression, and the whole workflow fails to process — every push to main shows a failed run named.github/workflows/local-only-runner-guard.ymlwith zero jobs (fleet audit 2026-09-15). This PR rewords those two strings; no logic change.Automated tests
None applicable: the change is to prose inside a workflow file. The proof is the
Reject hosted runner routingcheck on this PR, which now runs (the workflow parses) and passes.Manual (human) testing
Confirmed the workflow is accepted by GitHub: this PR's
Local-Only Workflow Runner Guardrun has a real job and a green result, whereas the previous main pushes show a zero-job failed run.🤖 Generated with Claude Code