Skip to content

01a077f5 - Configure AI accounts and roles without defaults - #72

Merged
TaprootFreak merged 4 commits into
DFXswiss:developfrom
JonnyLuca:codex/01a077f5-empty-configuration
Sep 7, 2026
Merged

01a077f5 - Configure AI accounts and roles without defaults#72
TaprootFreak merged 4 commits into
DFXswiss:developfrom
JonnyLuca:codex/01a077f5-empty-configuration

Conversation

@JonnyLuca

@JonnyLuca JonnyLuca commented Sep 7, 2026

Copy link
Copy Markdown
Contributor

EN:
Add explicitly configured AI accounts and freely named roles, with no installed account, model or role defaults. Bind model launches and optional billing reads to selected sessions, and require an explicit GitHub account for A38 visibility lookup.

DE:
Ergänzt explizit konfigurierte KI-Konten und frei benannte Rollen ohne vorinstallierte Konten, Modelle oder Rollen. Modellstarts und optionale Abrechnungsabfragen werden Sessions zugeordnet; die A38-Sichtbarkeitsabfrage benötigt ein explizites GitHub-Konto.

Implementation and migration
  • ai-accounts.json defines provider profile directories, named roles with explicit model/access, and interactive or lane session bindings. Missing or empty configuration authorizes no model launch. cmd_run validates the lane binding before registering a working agent, so configuration failures do not leave a false working-lane record.
  • Grok and Codex lane adapters resolve the configured role before launching. Interactive Grok sessions pin their conversation to the configured account, role, model, access and profile path; incompatible resume attempts are refused.
  • Child processes clear the documented ambient provider credentials and select the configured provider home. This selects process configuration; it is not a sandbox or proof of provider authentication.
  • Optional Grok billing reads require an explicit usage_session; there is no automatic host account or newest-session selection. The current billing adapter remains Grok-only.
  • A38 visibility lookup requires --github-session and uses the existing explicit GitHub account executor. Explicit visibility needs no GitHub lookup; the standalone CI guard retains its documented workflow-token contract.
  • Operators must configure profiles and session bindings before enabling launch paths after upgrading. Legacy unbound Grok conversation IDs require a new session.

The user authorized the Jonny fork publication route. No test or review waiver applies. This change does not deploy services or implement the complete issue-to-PR coordinator. Scripts retain responsibility for execution, GitHub communication, tests, lane starts and monitoring; model lanes return bounded work results.

Validated Ready evidence

Validated head: e33563c4c54129e0711b8d9dc67eb89bc5b8e05b.
Static-script full tests: 1477 passed, 3 skipped, 47 subtests passed in 110.23s (0:01:50).
Independent complete Grok inner review approved, followed by four independent PR review approvals: Grok quality and logic, then Codex quality and logic.
GitHub workflow inventory and check rollup are green on this head. The script verified the clean worktree, signature and formal approval by marassteiner.
Ready for review is not merged or completed; a human merges.

@JonnyLuca JonnyLuca left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Codex logic — rejected at a76d56a

src/agent_cli/main.py:2803 — cmd_run persists a working agent before launch() resolves the newly required AI session binding at lane.py:234. With missing, malformed, mismatched, or unauthorized configuration, launch fails before any provider process starts, but the store falsely retains a working lane. This is newly exposed by making empty/invalid AI configuration a normal fail-closed path. Resolve the binding before cmd_agent(start_args), or roll back/finish the agent record when pre-launch validation fails.

@marassteiner marassteiner left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Formal approval for e33563c4c54129e0711b8d9dc67eb89bc5b8e05b, submitted by the static executor through the explicitly selected separate review account.

Evidence verified before submission:

  • Four independent complete approvals on this exact head: Grok quality and logic, followed by Codex quality and logic; zero introduced findings.
  • Full static-script tests passed on the clean signed head.
  • Current-head GitHub workflow inventory and PR check rollup are green; PR is mergeable.

This publishes the recorded independent review results. It is not an additional model review and does not merge the PR. A human merges.

@JonnyLuca

Copy link
Copy Markdown
Contributor Author

Ready for review evidence for e33563c4c54129e0711b8d9dc67eb89bc5b8e05b:

  • Review-pass count: 4 independent, complete approvals on this head: Grok quality + logic, then Codex quality + logic. Zero introduced findings.
  • Static-script tests: 1477 passed, 3 skipped, 47 subtests passed in 110.23s (0:01:50) on the clean signed head.
  • GitHub Actions test: success; current-head workflow inventory and PR check rollup both verified green.
  • Formal GitHub approval by marassteiner verified on this head: 01a077f5 - Configure AI accounts and roles without defaults #72 (review).
  • Commit signature verified; PR is mergeable. The fork is explicitly authorized for this change.

This is Ready for review, not merged or completed; merge remains with a human.

@JonnyLuca
JonnyLuca marked this pull request as ready for review September 7, 2026 17:35
@TaprootFreak
TaprootFreak merged commit 2251407 into DFXswiss:develop Sep 7, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants