Add Google Drive silent install + DC exclusion on SID detection#60
Open
Gumbees wants to merge 4 commits into
Open
Add Google Drive silent install + DC exclusion on SID detection#60Gumbees wants to merge 4 commits into
Gumbees wants to merge 4 commits into
Conversation
Two scripts that work together to detect cloned/imaged machines that were not sysprepped. The workstation script stamps each machine's local SID into extensionAttribute1 on its AD computer object. The DC/admin script scans all computer objects for duplicate SIDs and reports findings with RMM custom field output. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
- Switch from extensionAttribute1 to info (Notes) field, which exists in all AD schemas without Exchange extensions - Add MACHINESID: prefix to stored values to avoid overwriting existing notes and to filter accurately during detection - Report script auto-migrates raw SID values from previous version - Detection script only picks up prefixed values via LDAP filter - Add full SID inventory output and HTML report for Ninja WYSIWYG field - Comment out Ninja-Property-Set calls by default Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Installs Google Drive for Desktop using winget when available, with automatic fallback to direct download from Google. Follows standard template with RMM/interactive dual-mode support. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Exits early if not running on a DC (DomainRole 4 or 5) since the script queries AD computer objects via ADSI and must run from a DC. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
![claude[bot]](https://avatars.githubusercontent.com/in/1236702?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code review is billed via overage credits. To resume reviews, an organization admin can raise the monthly limit at claude.ai/admin-settings/claude-code.
Once credits are available, push a new commit or reopen this pull request to trigger a review.
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds a silent Google Drive install script. Branch also carries the duplicate-SID detection scripts and a domain-controller role check that excludes DCs from the SID duplicate detection logic.
Files touched:
app-google-drive/google-drive-install.ps1... silent install for Google Drivemsft-windows/msft-windows-sid-detect-duplicates.ps1... duplicate SID detection (also inenhancement/duplicate-sid-detection) with added DC role exclusionmsft-windows/msft-windows-sid-report.ps1... SID report (also inenhancement/duplicate-sid-detection)Test plan
google-drive-install.ps1on a clean test endpoint and confirm Google Drive installs without UI prompts.msft-windows-sid-detect-duplicates.ps1on a domain controller and confirm it short-circuits without flagging.Lineage
Part of the stale-branch reconciliation sweep. Branch had 4 commits ahead of
mainwith no open PR. Shares the SID detection commits withenhancement/duplicate-sid-detection... opened as a separate PR so Nate can decide which to merge first; if both go in, the shared commits dedupe.