Skip to content

Vlad/profiling native test install subdir - #19257

Merged
vlad-scherbich merged 1 commit into
vlad/315-official-supportfrom
vlad/profiling-native-test-install-subdir
Jul 24, 2026
Merged

Vlad/profiling native test install subdir#19257
vlad-scherbich merged 1 commit into
vlad/315-official-supportfrom
vlad/profiling-native-test-install-subdir

Conversation

@vlad-scherbich

@vlad-scherbich vlad-scherbich commented Jul 23, 2026

Copy link
Copy Markdown
Contributor

prev: #19255 | next: #19250

Summary

INSTALL_SUBDIR for py3.15 native tests.

Test plan

  • CI green on this branch
  • Stack merges cleanly into the next PR's base branch

@datadog-official

This comment has been minimized.

@vlad-scherbich
vlad-scherbich force-pushed the vlad/profiling-native-test-install-subdir branch from a10eb9a to cf6728e Compare July 23, 2026 14:13
@vlad-scherbich
vlad-scherbich changed the base branch from main to vlad/315-peripheral-compat July 23, 2026 14:18
@vlad-scherbich
vlad-scherbich force-pushed the vlad/315-peripheral-compat branch from 0e9c0db to bf4de26 Compare July 23, 2026 14:31
@vlad-scherbich
vlad-scherbich force-pushed the vlad/profiling-native-test-install-subdir branch from cf6728e to 350791d Compare July 23, 2026 14:31
Allows version-specific native test binaries to install into a subdir
of the shared test/ directory (e.g. INSTALL_SUBDIR py315 -> test/py315/).

build_base_venvs runs in parallel across all Python versions and GitLab
merges all artifacts into a single directory for downstream jobs. Without
isolation a binary compiled for pyX.Y (RPATH -> libpythonX.Y) lands in
the shared test/ directory and crashes when the pytest gtest plugin tries
to run it against a different Python runtime.

Callers that do not pass INSTALL_SUBDIR are unaffected.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
@vlad-scherbich
vlad-scherbich force-pushed the vlad/315-peripheral-compat branch from bf4de26 to 32359ee Compare July 24, 2026 01:24
@vlad-scherbich
vlad-scherbich force-pushed the vlad/profiling-native-test-install-subdir branch from 350791d to 25b13ee Compare July 24, 2026 01:25
Base automatically changed from vlad/315-peripheral-compat to vlad/315-official-support July 24, 2026 01:25
@vlad-scherbich
vlad-scherbich merged commit 25b13ee into vlad/315-official-support Jul 24, 2026
4 of 7 checks passed
@vlad-scherbich
vlad-scherbich deleted the vlad/profiling-native-test-install-subdir branch July 24, 2026 01:25
@cit-pr-commenter-54b7da

Copy link
Copy Markdown

Codeowners resolved as

ddtrace/internal/datadog/profiling/stack/test/CMakeLists.txt            @DataDog/profiling-python

@cit-pr-commenter-54b7da

cit-pr-commenter-54b7da Bot commented Jul 24, 2026

Copy link
Copy Markdown

Circular import analysis

⚠️ Existing circular imports

There are 33 circular imports that already exist on the base branch and have not been changed by this PR.

Show existing cycles (showing 5 of 33 shortest)
ddtrace.internal.datastreams -> ddtrace.internal.datastreams.google_cloud_pubsub -> ddtrace.internal.datastreams
ddtrace.internal.datastreams -> ddtrace.internal.datastreams.kombu -> ddtrace.internal.datastreams
ddtrace.internal.datastreams -> ddtrace.internal.datastreams.aiokafka -> ddtrace.internal.datastreams
ddtrace.internal.core -> ddtrace._trace.span -> ddtrace.internal.core
ddtrace.internal.datastreams -> ddtrace.internal.datastreams.botocore -> ddtrace.internal.datastreams

To see all cycles, download the cycles-base.json and cycles-pr.json artifacts from this CI job and run:

uv run --script scripts/import-analysis/cycles.py compare cycles-base.json cycles-pr.json

@vlad-scherbich
vlad-scherbich restored the vlad/profiling-native-test-install-subdir branch July 24, 2026 01:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant