Refactor / Align asset structure with filamentphp#9
Refactor / Align asset structure with filamentphp#9thapacodes4u wants to merge 2 commits intoDataLinx:mainfrom
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #9 +/- ##
=========================================
Coverage 15.74% 15.74%
Complexity 89 89
=========================================
Files 13 13
Lines 254 254
=========================================
Hits 40 40
Misses 214 214 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
I think a plugin should contain 1 asset file and not separate ones for each feature? Unless Filament has a CSS/JS merge function for production, to reduce the number of files and therefore HTTP requests? |
|
@thapacodes4u please see my previous comment |
|
@SlimDeluxe Changes we did here was already added through another PR so we don't need this PR anymore and closing this |
Summary
Refactors the slider column asset registration to match the pattern used in the catalogue plugin for consistency across packages.
Changes
resources/dist/toresources/css/andresources/js/CommonServiceProviderto use__DIR__paths instead ofasset()helper