Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: ⛔ Files ignored due to path filters (2)
📒 Files selected for processing (4)
✅ Files skipped from review due to trivial changes (1)
🚧 Files skipped from review as they are similar to previous changes (3)
📝 WalkthroughWalkthroughAdds an optional ChangesRolling-major parameter and versioning
🎯 3 (Moderate) | ⏱️ ~20 minutes
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
action.yaml (1)
47-52:⚠️ Potential issue | 🟡 Minor | ⚡ Quick winUpdate
rollinginput description to reflect configurable major.Line 51 still documents the old fixed-major scheme (
0.1...) and only mentionsrolling-minor, which now conflicts with the newrolling-majorinput docs.Suggested doc fix
rolling: description: | For untagged releases, use a rolling versioning scheme. - When this is enabled, the default versioning scheme is 0.1.[commit count]+rev-[git sha]. To customize the SemVer minor version, set the `rolling-minor` option. + When this is enabled, the default versioning scheme is 0.1.[commit count]+rev-[git sha]. To customize the SemVer major/minor version, set `rolling-major` and `rolling-minor`.🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@action.yaml` around lines 47 - 52, The rolling input's description in action.yaml is out of date — it still documents a fixed major ("0.1...") and only mentions rolling-minor while a new rolling-major option exists; update the rolling input description to describe the new configurable major and minor scheme (e.g., "0.{rolling-major}.{rolling-minor}[commit count]+rev-[git sha]" or similar), mention both rolling-major and rolling-minor inputs and how they influence the generated version, and remove the outdated "0.1..." wording so the rolling description accurately reflects the current behavior of the rolling option.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@src/cli/mod.rs`:
- Around line 415-418: Update the validation error in the branch that checks
(Some(_), Some(_), _) if !self.rolling so the message mentions both
rolling-major and rolling-minor; specifically, in the function/method where the
flags self.rolling, rolling-major and rolling-minor are validated (the match arm
currently returning Err(eyre!(...))), change the error text to say you must
enable `rolling` to upload a release when both `rolling-major` and
`rolling-minor` are set (e.g. "You must enable `rolling` to upload a release
when both `rolling-major` and `rolling-minor` are specified.").
---
Outside diff comments:
In `@action.yaml`:
- Around line 47-52: The rolling input's description in action.yaml is out of
date — it still documents a fixed major ("0.1...") and only mentions
rolling-minor while a new rolling-major option exists; update the rolling input
description to describe the new configurable major and minor scheme (e.g.,
"0.{rolling-major}.{rolling-minor}[commit count]+rev-[git sha]" or similar),
mention both rolling-major and rolling-minor inputs and how they influence the
generated version, and remove the outdated "0.1..." wording so the rolling
description accurately reflects the current behavior of the rolling option.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: 4a4ce826-d319-4562-a53b-139afe00b58c
⛔ Files ignored due to path filters (2)
dist/index.jsis excluded by!**/dist/**dist/index.js.mapis excluded by!**/dist/**,!**/*.map
📒 Files selected for processing (3)
action.yamlsrc/cli/mod.rsts/index.ts
There was a problem hiding this comment.
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
src/cli/mod.rs (1)
421-421:⚠️ Potential issue | 🟠 Major | ⚡ Quick winMissing validation: both
rolling-majorandrolling-minorset withoutrolling.Line 421 matches when both
rolling_majorandrolling_minorare set, but it has no guard requiringself.rollingto be true. This means users can set both rolling version components without enabling therollingflag, which contradicts the validation logic on line 415 that requiresrollingwhen either component is set individually.The postfix logic at line 444 will append rolling-style suffixes (
.{commit_count}+rev-{revision}) because it checksself.rolling_major.0.is_some(), resulting in a rolling version even though the user didn't enablerolling.🛡️ Add validation guard
(None, Some(minor), _) => format!("0.{minor}"), - (Some(major), Some(minor), _) => format!("{major}.{minor}"), + (Some(_), Some(_), _) if !self.rolling => { + return Err(eyre!( + "You must enable `rolling` to upload a release with a specific `rolling-major` and `rolling-minor`." + )); + } + (Some(major), Some(minor), _) => format!("{major}.{minor}"), (None, None, _) if self.rolling => DEFAULT_ROLLING_PREFIX.to_string(),🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@src/cli/mod.rs` at line 421, When both rolling_major and rolling_minor are Some but self.rolling is not enabled the current match arm (Some(major), Some(minor), _) produces a rolling-style base version incorrectly; update the validation/branch that formats the base version (the match handling rolling_major / rolling_minor) to require self.rolling to be true before treating paired components as a rolling version (i.e., add a guard checking self.rolling or move this case behind a check like if self.rolling), and ensure the postfix logic that inspects rolling_major/rolling_minor also respects self.rolling so the rolling suffix (.{commit_count}+rev-{revision}) is only appended when self.rolling is true.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Outside diff comments:
In `@src/cli/mod.rs`:
- Line 421: When both rolling_major and rolling_minor are Some but self.rolling
is not enabled the current match arm (Some(major), Some(minor), _) produces a
rolling-style base version incorrectly; update the validation/branch that
formats the base version (the match handling rolling_major / rolling_minor) to
require self.rolling to be true before treating paired components as a rolling
version (i.e., add a guard checking self.rolling or move this case behind a
check like if self.rolling), and ensure the postfix logic that inspects
rolling_major/rolling_minor also respects self.rolling so the rolling suffix
(.{commit_count}+rev-{revision}) is only appended when self.rolling is true.
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: 3c5ed669-f986-4ee8-bfa1-46e951fbf014
⛔ Files ignored due to path filters (2)
dist/index.jsis excluded by!**/dist/**dist/index.js.mapis excluded by!**/dist/**,!**/*.map
📒 Files selected for processing (1)
src/cli/mod.rs
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@action.yaml`:
- Around line 39-45: Update the input description for the "rolling-major" action
input to document its prerequisites: state that "rolling-major" can only be used
when the "rolling" flag is true and that "rolling-minor" must also be provided
when "rolling-major" is set; reference the input names "rolling-major" and
"rolling-minor" in the description so users see the dependency and avoid invalid
combinations at runtime.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: d9f2b0e3-57f9-4479-b657-a27bf87735eb
⛔ Files ignored due to path filters (2)
dist/index.jsis excluded by!**/dist/**dist/index.js.mapis excluded by!**/dist/**,!**/*.map
📒 Files selected for processing (4)
README.mdaction.yamlsrc/cli/mod.rsts/index.ts
✅ Files skipped from review due to trivial changes (1)
- README.md
🚧 Files skipped from review as they are similar to previous changes (2)
- ts/index.ts
- src/cli/mod.rs
| rolling-major: | ||
| description: "Specify the SemVer major version of your rolling releases. All releases will follow the versioning scheme '[rolling-major].[rolling-minor].[commit count]+rev-[git sha]'" | ||
| required: false | ||
| default: null | ||
| rolling-minor: | ||
| description: "Specify the SemVer minor version of your rolling releases. All releases will follow the versioning scheme '0.[rolling-minor].[commit count]+rev-[git sha]'" | ||
| description: "Specify the SemVer minor version of your rolling releases. All releases will follow the versioning scheme '[rolling-major].[rolling-minor].[commit count]+rev-[git sha]'" | ||
| required: false |
There was a problem hiding this comment.
Document rolling-major prerequisites to avoid invalid input combinations.
rolling-major is currently documented as standalone, but downstream CLI validation requires rolling=true and also requires rolling-minor when rolling-major is set. Please include that constraint in this input description to prevent avoidable action failures at runtime (e.g., “rolling-major requires rolling and rolling-minor”).
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@action.yaml` around lines 39 - 45, Update the input description for the
"rolling-major" action input to document its prerequisites: state that
"rolling-major" can only be used when the "rolling" flag is true and that
"rolling-minor" must also be provided when "rolling-major" is set; reference the
input names "rolling-major" and "rolling-minor" in the description so users see
the dependency and avoid invalid combinations at runtime.
1 participant
Summary by CodeRabbit