Skip to content

Allow configuring the rolling major #323

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
cole-h wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Allow configuring the rolling major #323

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1c60e34
Allow configuring the rolling major
cole-h Jun 4, 2026
6ac6b5c
npm run all
cole-h Jun 9, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -198,7 +198,8 @@ If different flakes have different release strategies, for example one flake use
| `tag` | The Git tag to use for non-rolling releases. This must be the character `v` followed by a SemVer version, such as `v0.1.1`. | string | | |
| `rev` | The Git revision SHA to use for non-rolling releases. | string | | |
| `rolling` | For untagged releases, use a [rolling versioning scheme][rolling]. When this is enabled, the default versioning scheme is `0.1.[commit count]+rev-[git sha]`. To customize the [SemVer] minor version, set the `rolling-minor` option. | Boolean | | `false` |
| `rolling-minor` | Specify the [SemVer] minor version of your [rolling releases][rolling]. All releases will follow the versioning scheme `0.[rolling-minor].[commit count]+rev-[git sha]`. | string | | |
| `rolling-major` | Specify the [SemVer] major version of your [rolling releases][rolling]. All releases will follow the versioning scheme `[rolling-major].[rolling-minor].[commit count]+rev-[git sha]`. | string | | |
| `rolling-minor` | Specify the [SemVer] minor version of your [rolling releases][rolling]. All releases will follow the versioning scheme `[rolling-major].[rolling-minor].[commit count]+rev-[git sha]`. | string | | |
| `git-root` | The root directory of your Git repository. | relative path | | `.` |
| `extra-labels` | `flakehub-push` automatically uses the GitHub repo's topics as labels. This `extra-labels` parameter enables you to add extra labels beyond that as a comma-separated string. Only alphanumeric characters and hyphens are allowed in labels and the maximum length of labels is 50 characters. You can specify a maximum of 20 extra labels, and have a maximum of 25 labels, including those that we retrieve from GitHub. Any labels after the 25th will be ignored. | string | | `""` |
| `spdx-expression` | A valid SPDX license expression. This will be used in place of what GitHub claims your repository's `spdxIdentifier` is. | string | | `""` |
Expand Down
6 changes: 5 additions & 1 deletion action.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,8 +36,12 @@ inputs:
description: The Git revision SHA to use for non-rolling releases.
required: false
default: null
rolling-major:
description: "Specify the SemVer major version of your rolling releases. All releases will follow the versioning scheme '[rolling-major].[rolling-minor].[commit count]+rev-[git sha]'"
required: false
default: null
rolling-minor:
description: "Specify the SemVer minor version of your rolling releases. All releases will follow the versioning scheme '0.[rolling-minor].[commit count]+rev-[git sha]'"
description: "Specify the SemVer minor version of your rolling releases. All releases will follow the versioning scheme '[rolling-major].[rolling-minor].[commit count]+rev-[git sha]'"
required: false
Comment on lines +39 to 45

@coderabbitai coderabbitai Bot Jun 9, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟡 Minor | ⚡ Quick win

Document rolling-major prerequisites to avoid invalid input combinations.

rolling-major is currently documented as standalone, but downstream CLI validation requires rolling=true and also requires rolling-minor when rolling-major is set. Please include that constraint in this input description to prevent avoidable action failures at runtime (e.g., “rolling-major requires rolling and rolling-minor”).

🤖 Prompt for AI Agents 
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@action.yaml` around lines 39 - 45, Update the input description for the
"rolling-major" action input to document its prerequisites: state that
"rolling-major" can only be used when the "rolling" flag is true and that
"rolling-minor" must also be provided when "rolling-major" is set; reference the
input names "rolling-major" and "rolling-minor" in the description so users see
the dependency and avoid invalid combinations at runtime.

default: null
rolling:
Expand Down
4 changes: 4 additions & 0 deletions dist/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -108413,6 +108413,7 @@ var FlakeHubPushAction = class extends DetSysAction {
this.rolling = inputs_exports.getBool("rolling");
this.mirror = inputs_exports.getBool("mirror");
this.name = inputs_exports.getStringOrNull("name");
this.rollingMajor = inputs_exports.getNumberOrNull("rolling-major");
this.rollingMinor = inputs_exports.getNumberOrNull("rolling-minor");
}
async main() {
Expand Down Expand Up @@ -108459,6 +108460,9 @@ var FlakeHubPushAction = class extends DetSysAction {
if (this.name !== null) {
env.FLAKEHUB_PUSH_NAME = this.name;
}
if (this.rollingMajor !== null) {
env.FLAKEHUB_PUSH_ROLLING_MAJOR = this.rollingMajor.toString();
}
if (this.rollingMinor !== null) {
env.FLAKEHUB_PUSH_ROLLING_MINOR = this.rollingMinor.toString();
}
Expand Down
Loading
Loading