Conversation
…ister-app-in-macos-no
Owner
Author
|
@codex review |
…ister-app-in-macos-no
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 78bdf33e28
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
…ister-app-in-macos-no
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
new Audio(...).play()registered the app with macOS Now Playing / Media Control Center and could cause device focus switching; the change removes that behavior by using the Web Audio API.Description
HTMLAudioElementinsrc/utils/notificationSounds.tswith a Web Audio API implementation thatfetches, decodes, and plays anAudioBuffervia aBufferSourceandGainNodeat low gain.AudioContextresolution/reuse with support forAudioContextand legacywebkitAudioContext, and callresume()when the context issuspendedbefore playback.audio/<label> load/play error.src/utils/notificationSounds.test.ts(jsdom environment) covering successful playback, fetch failure debug logging, and suspended-context resume behavior, and replaceglobalusage withglobalThiswhere needed for typecheck compatibility.Testing
npm run test -- src/utils/notificationSounds.test.ts, which passed (3 tests passed).npm run typecheckand the full test suite withnpm run test, and the typecheck and full suite completed successfully (typecheck passed and all tests passed).// @vitest-environment jsdomto the new test file, after which the tests passed.Codex Task