refactor(core): remove dead output-parser facade + dead branches (#156) - #195
Open
Galmanus wants to merge 1 commit into
Open
refactor(core): remove dead output-parser facade + dead branches (#156)#195Galmanus wants to merge 1 commit into
Galmanus wants to merge 1 commit into
Conversation
- Delete the stellar-cli-output-parser façade: no production caller imported it (all use parse-contract-id/parse-wasm-hash/version directly) and it was not re-exported from index. Its only coverage of parseStellarCliVersion is preserved in a new version.test.ts. - probeMissingStellarCliFeatures: below the minimum version, report every required feature (contract-build/deploy/invoke-sign), not just contract-invoke-sign. - ensureRootBindingIndex: collapse the two return-without-write branches (matches / differs) into a single 'existing index is preserved' path; behavior is unchanged, the redundant equality check is gone. - version.ts: drop the __filename fallback. The CJS build shims import.meta.url via a tsup banner, so createRequire(import.meta.url) resolves in ESM source, ESM dist, and CJS dist alike. Closes Dione-b#156
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #156. Each of the four items was verified against the source before touching it.
1. Unused output-parser façade — deleted
stellar-cli/stellar-cli-output-parser.tswas imported only by its own test; every production caller importsparse-contract-id/parse-wasm-hash/versiondirectly, and it is not re-exported fromindex.ts. Deleted it (the issue's second option).Coverage note: the façade test was the only test exercising
parseStellarCliVersion(there was noversion.test.ts). Those two cases are preserved in a newstellar-cli/version.test.tsimporting the parser directly, so no coverage is lost.2. Below-min probe underreported — fixed
probeMissingStellarCliFeatures, whenversion < STELLAR_CLI_MIN_VERSION, returned only["contract-invoke-sign"], silently omittingcontract-buildandcontract-deploy. Now returns all ofSTELLAR_CLI_REQUIRED_FEATURES. Added a unit test (the below-min branch returns early, so it needs no live CLI).3.
ensureRootBindingIndexdead branch — collapsedBoth the "matches" and "differs" cases returned without writing; only the catch (file absent) wrote. Collapsed to
try { readFile; return } catch { writeFile }, keeping a comment documenting that any existing index is preserved. Behavior unchanged — the 16 existing binding-patch tests still pass.4.
version.ts__filenameguard — removedVerified safe: the CJS build (
dist/index.cjs) rewritesimport.meta.urlvia a tsup banner shim (pathToFileURL(__filename).href), socreateRequire(import.meta.url)resolves in the ESM source, the ESM dist, and the CJS dist. Thedeclare const __filenameternary was genuinely redundant.Verification
tsc --noEmitclean; full core suite 496/496 pass (86 files).