Color: declare EITHER + drive setShaderSRGBConversion from atlas encoding [ADR-021/#409]#27
Merged
Conversation
…s encoding [ADR-021/#409] Pairs with displayxr-runtime #419 (ADR-021 color contract + Model B). Verified end-to-end on Leia hardware. - D3D11 DP declares XRT_DP_COLOR_EITHER and implements set_atlas_encoding; process_atlas drives leiasr_d3d11_set_srgb_conversion(read=false, write=(atlas == LINEAR)) so the weaver performs the matched output encode under Model B. The process_atlas `format` arg stays the real DXGI format. - D3D12/GL DPs: doc-only (stay Model-A/ENCODED passthrough; exposing the weaver setter + declaring EITHER there is a tracked follow-up). Requires runtime headers with the appended get_handoff_color_capability + set_atlas_encoding slots (ABI major v2, append-only -- no major bump). Bump DXR_RUNTIME_GIT_TAG to the runtime release that includes #419 before CI/merge. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
…ing) Bump DXR_RUNTIME_GIT_TAG + workflow RUNTIME_REF from v1.9.0 to the merged displayxr-runtime#419 commit (82b68ed1) so the plug-in builds against the appended get_handoff_color_capability + set_atlas_encoding DP-vtable slots. Re-pin to a runtime release tag at the next coupled versioned release. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pairs with displayxr-runtime #419 (ADR-021 color contract + Model B). Verified end-to-end on Leia hardware.
What changed
XRT_DP_COLOR_EITHER(get_handoff_color_capability) and implementsset_atlas_encoding.process_atlasdrivesleiasr_d3d11_set_srgb_conversion(read=false, write=(atlas == LINEAR))so the SR weaver performs the matched output encode when the runtime composes in linear (Model B). Theprocess_atlasformatarg stays the real DXGI format (used forsetInputViewTexture).This needs runtime headers that ship the appended
get_handoff_color_capability+set_atlas_encodingDP-vtable slots (ABI major v2, append-only — no major bump). The pin here is stillDXR_RUNTIME_GIT_TAG = v1.9.0, which predates those slots, so CI (FetchContent) will fail until runtime #419 is merged and a runtime release is tagged, then bumpDXR_RUNTIME_GIT_TAGto that tag. Local builds succeed viaDXR_RUNTIME_SOURCE_DIR.Back-compat: because the slots are append-only and absent ⟹ ENCODED, an old runtime + this plugin = Model A, and a new runtime + old plugin = Model A. No lock-step required beyond the pin bump.
🤖 Generated with Claude Code