Limit bulk relationship builds to stored maps - #90
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Stobe's bulk relationship build queued every NPC found in event history. On the local playthrough this meant 643 pending NPCs, causing broad proximity-derived relationships, excessive LLM requests, and truncation failures.
Change
extended_datawithout an LLM request.Compatibility
No schema migration is required. Existing built relationships remain skipped unless Force Rebuild is selected.
HerikaServer already uses the limited stored-relationship scope. DialecticServer has no equivalent bulk UI and its internal batch analysis already requires stored relationships, so no sibling port is needed.
Validation
php -l ext/relationship_system/batch_build.phpphp -l ext/relationship_system/relationship_llm.phpphp -l tests/relationship_system_regression.phpSTOBE_DB_NAME=stobe_test php tests/relationship_system_regression.phpgit diff --check origin/unstable...HEADDeployment
Not deployed.
Limits
No browser or in-game bulk build was performed. The separate per-NPC connector-selection issue and faction full-snapshot cleanup issue are outside this PR.