CI: consolidate pytest options into PYTEST_OPTS_BASE #8777
+84
−12
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cdecker
force-pushed
the
202511-pytext-reprot
branch
2 times, most recently
from
139f138 to
b4451b8
Compare
Replaces GLOBAL_PYTEST_OPTS with PYTEST_OPTS_BASE that includes all common pytest options: --reruns=10, -vvv, --junit-xml=report.xml, --timeout=1800, and --durations=10. Removes redundant option specifications from individual jobs and simplifies pytest command invocations by removing direct references to GLOBAL_PYTEST_OPTS (now inherited via PYTEST_OPTS). 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com> Changelog-None
Adds upload-artifact steps after each test run to preserve test results as GitHub artifacts. Each job uploads its report.xml with a unique name based on the job and matrix configuration. Artifacts are uploaded even when tests fail (if: always()) to ensure test results are available for debugging. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
GitHub Actions doesn't allow referencing workflow-level env variables
from job-level env sections. Fixed by:
- Replacing ${{ env.PYTEST_OPTS_BASE }} with full values in job-level env
- Keeping ${{ env.PYTEST_OPTS_BASE }} in step-level env (which is valid)
This resolves the "Unrecognized named-value: 'env'" errors.
🤖 Generated with [Claude Code](https://claude.com/claude-code)
Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
The valgrind and sanitizer test matrix names contain parentheses and slashes (e.g., 'Valgrind (01/10)', 'ASan/UBSan (01/12)') which are invalid in artifact filenames. Replace these characters with hyphens to ensure reliable artifact uploads. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Haiku 4.5 <noreply@anthropic.com>
… NAME Add a GROUP matrix variable to valgrind and sanitizer test configurations with simple numeric values. Use matrix.GROUP in artifact names instead of sanitizing the descriptive NAME, which contains special characters. This is cleaner and more maintainable than string replacement logic. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Haiku 4.5 <noreply@anthropic.com>
cdecker
force-pushed
the
202511-pytext-reprot
branch
from
b4451b8 to
f9029ab
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Consolidates
GLOBAL_PYTEST_OPTSandPYTEST_OPTS_BASEinto a singlePYTEST_OPTS_BASEvariable that includes all common pytest options.Changes
Replaced
GLOBAL_PYTEST_OPTSwithPYTEST_OPTS_BASEcontaining:--reruns=10- Retry flaky tests-vvv- Verbose output--junit-xml=report.xml- JUnit XML test reporting--timeout=1800- 30-minute timeout (unified from mixed 1200/1800)--durations=10- Show 10 slowest testsSimplified job configurations by removing redundant option specifications from 6 jobs
Cleaned up pytest command invocations by removing direct
${GLOBAL_PYTEST_OPTS}references (now inherited via${PYTEST_OPTS})Removed duplicate
-vvvflags from command linesBenefits
Test plan