Add opt-in Party Target frames to party frames - #1510
Conversation
|
hey! thanks this looks promising. can i get a picture of the options? i think the targets should be much smaller relative to the actual party frames, similar to target unit frame vs target of target unit frame. |
|
Change to party target frame size as suggested by @EllesmereGaming.
|
|
Updated PR and my changes to match the 8.9.3 codebase. |
|
we do have a feature halt currently but I am looking at potentially bringing this in next patch! |
Hi there, I was wondering if this is still in the plans to be brought into the main release or to remain in a holding pattern? |
apainter2
left a comment
There was a problem hiding this comment.
Reviewed changes with several versions of EllemereUI code and no issues.
Adds a minimal, opt-in Party Target feature: a small clickable secure frame next to each party member showing that member's current target (party1target..party4target). Left-click targets the unit via secure attributes so it works in combat with no taint. The feature is Party-only and defaults OFF. It builds lazily on first enable (no frames, events, or work while disabled), is event-driven (UNIT_TARGET/UNIT_NAME_UPDATE/GROUP_ROSTER_UPDATE) with no OnUpdate or polling, and uses RegisterUnitWatch for visibility. Raid frames are untouched. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Scale party target frames to ~0.56x width / ~0.55x height of their owner party button, mirroring EllesmereUI's Target vs Target-of-Target size convention so the party -> party-target pairing reads clearly. Sizing is applied in the existing out-of-combat _PT_Layout pass; no raid frame code paths are touched. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
b272afb to
c729cad
Compare


Adds a minimal, opt-in Party Target feature: a small clickable secure frame next to each party member showing that member's current target (party1target..party4target). Left-click targets the unit via secure attributes so it works in combat with no taint.
The feature is Party-only and defaults OFF. It builds lazily on first enable (no frames, events, or work while disabled), is event-driven (UNIT_TARGET/UNIT_NAME_UPDATE/GROUP_ROSTER_UPDATE) with no OnUpdate or polling, and uses RegisterUnitWatch for visibility. Raid frames are untouched.
What does this PR do?
Adds a minimal, opt-in Party Target feature: a small clickable frame next to each party member showing that member's current target (party1target..party4target). Left-click targets/selects that unit. Similar to a feather offered by Shadow Unit Frames and ElvUI.
It is a native extension of the existing party frame architecture in EllesmereUIRaidFrames.lua (the module that owns both party and raid frames). The feature is Party-only and defaults OFF.
Configuration: Options -> Raid Frames -> Party tab -> FRAMES -> "Enable Party Targets".
Files changed:
How was it tested?
Live retail client. Verified: feature off = no frames/events; enabling shows target frames next to party members; name appears/updates on target change; left-click selects the unit (in and out of combat); frame hides when the member clears their target; disabling hides frames and stops work. Raid frames verified unchanged. No Lua errors.
Screenshots
Before:

After:

Checklist