zhTW: translate 36 new keys for the Chat Bubbles page and Rotation Assist - #2047
Open
LoChinAn wants to merge 1 commit into
Open
zhTW: translate 36 new keys for the Chat Bubbles page and Rotation Assist#2047LoChinAn wants to merge 1 commit into
LoChinAn wants to merge 1 commit into
Conversation
Covers the two v9.1.8 additions that shipped untranslated: the Chat Bubbles page (channel picker, appearance sliders, enable popup and the instance warning) and the Cooldown Manager's Rotation Assist style row. Terms follow the client's own zhTW strings wherever one exists, and tooltips reuse the exact option names the player sees on the same page, including the existing Party and Raid renderings. Also replaces the Chat module's searchTerms haystack. Upstream appended the bubble keywords to it, so the previous key can never be looked up again -- L() is an exact table lookup. The Chinese search words carry over unchanged plus the new bubble terms.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Only
EllesmereUILocales/zhTW.luais touched: 37 lines added, 1 replaced. No module code, no.toc, no other locale.The keys come from the two v9.1.8 additions that shipped untranslated: the Chat Bubbles page (24 keys - the enable gate and its confirm popup, the channel picker with its per-channel tooltips, the "Only works outside of Instances" banner, and the appearance sliders/swatches) and the Cooldown Manager's Rotation Assist style row (9 keys - style dropdown, colour mode, thickness and outset), plus 3 keys shared by both pages and the general page. Scanned incrementally from
0df54bbto271ffc3.Wording follows the client's own zhTW strings wherever one exists, so the options page reads like the rest of the UI:
Chat Bubblesuses the client's對話泡泡(CHAT_BUBBLES_TEXT), and the channel labels use說/大喊(SAY/YELL). Tooltips reference options by the exact name the player sees on the same page rather than a literal translation of the English - the party channel tooltip says小隊because that is whatL["Party"]already renders, and the Rotation Assist tooltip points at Blizzard's suggestion by the name the client uses for it,輔助醒目標示(ASSISTED_COMBAT_HIGHLIGHT_LABEL).Solid Borderfollows the existingL["Solid"] = "實心"used for border styles, andRotation Assistfollows the neighbouring rowHide Rotation Helper=隱藏輸出循環輔助so the two rows agree.The one replaced line is the Chat module's
searchTermshaystack. Upstream appendedbubbles bubble speech balloon nameplateto it, and sinceL()is an exact table lookup the old key could never be hit again; the Chinese search words carry over unchanged with the bubble terms added, so nothing that used to be searchable stops being searchable.Compiles under Lua 5.1, round-trips through the catalog parser, UTF-8 without BOM, CRLF like the sibling locale files.
Checklist