Fix: Re-strip events from disposed Blizzard action buttons on re-Show - #2079
Open
svart2521 wants to merge 1 commit into
Open
Fix: Re-strip events from disposed Blizzard action buttons on re-Show#2079svart2521 wants to merge 1 commit into
svart2521 wants to merge 1 commit into
Conversation
Bug: Issue: Blizzard's periodic re-init of a disposed MultiBarBottomLeft button (hidden via QuietlyHideBlizzButton) re-registers its default events onto an already-tainted button, so the next native cooldown update rejects secret start/duration values with "bad argument #1 to SetCooldown". Fix: Mirrored the existing bar-level OnShow re-hide hook onto QuietlyHideBlizzButton itself, so a button's own re-init gets silently re-stripped of events too.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug: https://discord.com/channels/585577383847788554/1545795450811056130
Issue: Blizzard's periodic re-init of a disposed MultiBarBottomLeft button (hidden via QuietlyHideBlizzButton) re-registers its default events onto an already-tainted button, so the next native cooldown update rejects secret start/duration values with "bad argument #1 to SetCooldown".
Fix: Mirrored the existing bar-level OnShow re-hide hook onto QuietlyHideBlizzButton itself, so a button's own re-init gets silently re-stripped of events too.