Skip to content

Fix: Re-strip events from disposed Blizzard action buttons on re-Show #2079

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
svart2521 wants to merge 1 commit into
base: main
Choose a base branch
from
+6 −0
Open

Fix: Re-strip events from disposed Blizzard action buttons on re-Show #2079

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions EllesmereUIActionBars/EllesmereUIActionBars.lua
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -940,6 +940,12 @@ hiddenParent:Hide()
function ns.QuietlyHideBlizzButton(btn)
btn:UnregisterAllEvents()
btn:SetAttributeNoHandler("statehidden", true)
-- Blizzard's own re-init re-registers events (incl. cooldown) on this
-- already-tainted button; re-strip them on its next OnShow.
if not btn._eabReassertHide then
btn._eabReassertHide = true
btn:HookScript("OnShow", function(self) self:UnregisterAllEvents() end)
end
end

-- Re-hide a stock bar Blizzard just re-Show()'d, without calling Hide() or
Expand Down