test(frontend): Match setup route assertion to formatter - #56
Open
Emran025 wants to merge 1 commit into
Open
Conversation
Keep the source-contract assertion compatible with the repository single-quote Prettier policy so the quality workflow can execute the onboarding suite.
Emran025
force-pushed
the
test/setup-route-format-contract
branch
from
August 18, 2026 03:49
3ec3657 to
0ab1ec0
Compare
Owner
Author
|
Technical review update: The source-contract assertions were corrected to match the committed Prettier This PR is not eligible for merge yet because the quality workflow now stops at the independent i18n gate: I will keep this PR open and will merge only after all required checks are successful. |
This was referenced Aug 18, 2026
Emran025
pushed a commit
that referenced
this pull request
Aug 18, 2026
Assert catalog entries and static setup routing independently of formatter-selected quote style, removing the unrelated test failure that prevented the i18n remediation from reaching its validation gate.\n\nRefs #56.
Emran025
added a commit
that referenced
this pull request
Aug 18, 2026
* fix(i18n): document technical setup aria identifier Classify SetupSection's dynamic aria-labelledby identifier as a documented approved exception, record its rationale in the inventory policy, and enforce that approved exceptions have policy documentation.\n\nFixes #29. * test(frontend): tolerate formatted setup assertions Assert catalog entries and static setup routing independently of formatter-selected quote style, removing the unrelated test failure that prevented the i18n remediation from reaching its validation gate.\n\nRefs #56. * fix(i18n): match approved exceptions semantically Derive approved exceptions from stable policy constraints including source path, JSX attribute, and literal template shape rather than formatter-sensitive source coordinates.\n\nKeep generic taxonomy entries documentary-only and reject undocumented approved statuses. Refs #29. --------- Co-authored-by: Emran025 <1.48263577e+08+Emran025@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Corrects the setup catch-all route source-contract assertion so it matches the repository Prettier configuration (
singleQuote: true).Root cause
The quality workflow formats frontend code before the onboarding test reads the route source. Prettier converts the route to single quotes, while the test expected a double-quoted source fragment, causing unrelated pull requests to fail.
Validation
git diff --checkpasses.Fixes the quality-gate regression identified while reviewing #55.