Skip to content

fix: resolve pagination termination logic and empty page fallback - #12

Open
Saadat555 wants to merge 1 commit into
EncarnacionP:mainfrom
Saadat555:fix-pagination
Open

Saadat555 wants to merge 1 commit into
EncarnacionP:mainfrom
Saadat555:fix-pagination

Conversation

@Saadat555

Copy link
Copy Markdown

Resolves #1

This PR fixes the pagination issues identified in Issue #1 by ensuring that the pagination loop terminates correctly:

  1. It parses the Link header accurately using regex to find the rel="next" page URL.
  2. It explicitly checks for empty API responses (len(issues) == 0) and safely aborts to prevent infinite loop regressions, as requested in the acceptance criteria.
  3. It enforces the requested total limit natively.
  4. Unit tests have been adjusted/added to properly simulate sparse/partial pages and the empty-page circuit breaker.

/claim #1

@opirebot

opirebot Bot commented Sep 17, 2026

Copy link
Copy Markdown

😅 Unfortunately there are no rewards left to claim in this issue!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

🎯 Fix premature termination in API pagination when page size is less than requested

1 participant