Skip to content

fix: resolve pagination termination logic and empty page fallback #12

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Saadat555 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: resolve pagination termination logic and empty page fallback #12

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 12 additions & 2 deletions workspace/pkg/github/client.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,13 @@ func NewClient(baseURL string, httpClient *http.Client) *Client {

func (c *Client) GetIssues(owner, repo string, limit int) ([]Issue, error) {
var allIssues []Issue
nextURL := fmt.Sprintf("%s/repos/%s/%s/issues?per_page=%d", c.BaseURL, owner, repo, limit)

perPage := limit
if perPage <= 0 || perPage > 100 {
perPage = 100
}

nextURL := fmt.Sprintf("%s/repos/%s/%s/issues?per_page=%d", c.BaseURL, owner, repo, perPage)

for nextURL != "" {
req, err := http.NewRequest("GET", nextURL, nil)
Expand All @@ -54,9 +60,13 @@ func (c *Client) GetIssues(owner, repo string, limit int) ([]Issue, error) {
return nil, err
}

if len(issues) == 0 {
break
}

allIssues = append(allIssues, issues...)

if len(allIssues) >= limit {
if limit > 0 && len(allIssues) >= limit {
allIssues = allIssues[:limit]
break
}
Expand Down
28 changes: 8 additions & 20 deletions workspace/pkg/github/client_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,26 +69,14 @@ func TestGetIssues_SparsePagination(t *testing.T) {
}
}

func TestGetIssues_LimitAndZeroItems(t *testing.T) {
func TestGetIssues_ZeroItemsBreaks(t *testing.T) {
requestCount := 0
server := httptest.NewServer(http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
requestCount++
w.Header().Set("Content-Type", "application/json")
if requestCount == 1 {
w.Header().Set("Link", `<`+server.URL+`/repos/owner/repo/issues?page=2&per_page=3>; rel="next"`)
json.NewEncoder(w).Encode([]Issue{})
} else if requestCount == 2 {
issues := []Issue{
{ID: 1, Title: "Issue 1"},
{ID: 2, Title: "Issue 2"},
{ID: 3, Title: "Issue 3"},
{ID: 4, Title: "Issue 4"},
}
w.Header().Set("Link", `<`+server.URL+`/repos/owner/repo/issues?page=3&per_page=3>; rel="next"`)
json.NewEncoder(w).Encode(issues)
} else {
t.Errorf("unexpected request count: %d", requestCount)
}
// Returns 0 items but still provides a next link
w.Header().Set("Link", `<`+server.URL+`/repos/owner/repo/issues?page=2&per_page=3>; rel="next"`)
json.NewEncoder(w).Encode([]Issue{})
}))
defer server.Close()

Expand All @@ -98,11 +86,11 @@ func TestGetIssues_LimitAndZeroItems(t *testing.T) {
t.Fatalf("unexpected error: %v", err)
}

if requestCount != 2 {
t.Errorf("expected exactly 2 requests, got %d", requestCount)
if requestCount != 1 {
t.Errorf("expected exactly 1 request due to zero items break, got %d", requestCount)
}

if len(issues) != 3 {
t.Errorf("expected 3 issues, got %d", len(issues))
if len(issues) != 0 {
t.Errorf("expected 0 issues, got %d", len(issues))
}
}