Fix: Extend timeout for docs deployment to 30 mins#1266
Merged
Conversation
It's currently timing out while trying to build all the old versions of the docs. This isn't normally an issue as much of this work is cached, but without the cache it apparently takes longer than the 10 mins limit we currently have. Extend it to 30 mins. Fixes #1265.
Contributor
There was a problem hiding this comment.
Pull request overview
Extends the GitHub Actions job timeout for the docs deployment workflow to prevent CI failures when rebuilding all documentation versions without a warm cache.
Changes:
- Increase
deploy-docsbuild job timeout from 10 minutes to 30 minutes.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1266 +/- ##
=======================================
Coverage 89.74% 89.74%
=======================================
Files 57 57
Lines 8195 8195
Branches 8195 8195
=======================================
Hits 7355 7355
Misses 544 544
Partials 296 296 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Member
Author
|
Successfully deployed in 11m15s 🚀 |
11 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
It's currently timing out while trying to build all the old versions of the docs. This isn't normally an issue as much of this work is cached, but without the cache it apparently takes longer than the 10 mins limit we currently have. Extend it to 30 mins.
I've left the timeout for the link-checker workflow at 10 mins for now, even though that also involves building the docs, because it only builds the latest version of the docs, so shouldn't be as time consuming. We can always revise this.
Fixes #1265.
Type of change
Key checklist
$ cargo test$ cargo docpresent in the previous release
Further checks