Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #490 +/- ##
==========================================
- Coverage 95.03% 95.03% -0.01%
==========================================
Files 36 36
Lines 4914 4893 -21
Branches 4914 4893 -21
==========================================
- Hits 4670 4650 -20
Misses 123 123
+ Partials 121 120 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
10 tasks
alexdewar
approved these changes
Apr 23, 2025
Member
alexdewar
left a comment
There was a problem hiding this comment.
I think I prefer this to #489 (although that is ok as a solution too). It's just a bit simpler. The only downside is that some things look a bit uglier with extra &s and clone()s, but I'm not sure it's worth having custom structs just to avoid that.
Collaborator
Author
|
Ok thanks, I'll go ahead with this approach then, and give it a go for the remaining maps still left to implement. Can always switch back to custom structs later if we feel it's necessary, but I doubt it |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Turning existing map structs into type aliases. Removes a lot of code, with only minor refactoring required
Fixes # (issue)
Type of change
Key checklist
$ cargo test$ cargo docFurther checks