fix(test): stop the SEA e2e test's own timeout race from swallowing diagnostics - #30
Merged
Merged
Conversation
…iagnostics sea (macos-26-intel) failed a second time, burning through the whole SEA_BINARY_STARTUP_TIMEOUT_MS budget with zero success — but the outer test() timeout was set equal to that same budget, so vitest's own abort raced this test's catch block and won, discarding every byte of captured stderr and leaving nothing to diagnose from. Logs stderr as it arrives instead of only from the catch block, tracks the child's own exit/spawn-error state, and gives the outer test() timeout real headroom over the inner poll deadline so this test's own diagnostic Error is what actually surfaces as the failure.
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
🎉 This PR is included in version 1.2.7 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
sea (macos-26-intel) failed a second time, burning through the entire SEA_BINARY_STARTUP_TIMEOUT_MS budget with zero success, but the outer test() timeout was set equal to that same budget — vitest's own abort raced this test's catch block and won, discarding every byte of captured stderr and leaving nothing to actually diagnose from. Logs stderr as it arrives, tracks the child's own exit/spawn-error state, and gives the outer timeout real headroom over the inner poll deadline so the next failure (if there is one) actually tells us what's happening.