fix: reject an invalid identity name before offering the creation wizard - #14
Merged
Merged
Conversation
This was referenced Sep 11, 2026
Mearman
marked this pull request as ready for review
September 11, 2026 07:47
Member
Author
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
The @<name> shortcut passes its name portion through verbatim, so an email-shaped argument like @joseph.mearman@exadev.io reached runIdentityWizard unchanged. The wizard prompted "Create it now?" and only threw InvalidIdentityNameError after the user confirmed, an interaction that offers an action it can never perform. Validate the name against IdentitySchema at the top of the wizard, the single choke point both the @<name> shortcut and `identity use` route through, so the clean one-line error fires before any prompt appears.
Mearman
force-pushed
the
validate-identity-name-before-wizard
branch
from
September 11, 2026 07:58
e418ca4 to
d4b1ff6
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
@<name>shortcut passes its name portion through verbatim, so an email-shaped argument like@joseph.mearman@exadev.ioreachedrunIdentityWizardunchanged. The wizard prompted "Create it now?" and only threwInvalidIdentityNameErrorafter the user selected Create — an interaction that offers an action it can never perform.This validates the name against
IdentitySchemaat the top of the wizard, the single choke point both the@<name>shortcut andidentity useroute through, so the clean one-line error fires before any prompt appears:Continues the raw-throw-to-CliError sweep already on main (d03712a, 74cfe16, 423eddf): 2.0.1 already stopped
addIdentitycrashing with a rawZodError; this closes the remaining interactive gap where a doomed name was still offered the wizard.