fix(ci): rewrite release pushes to SSH so the deploy key actually authenticates - #10
Merged
Merged
Conversation
…henticates actions/checkout's ssh-key input only wires the deploy key into core.sshCommand for its own git operations -- it never rewrites the "origin" remote or any later command's push URL. @semantic-release/git builds its push against a plain https://github.com/... URL, which the still-active default-token credential (persist-credentials) satisfied instead of the deploy key, so the previous fix never actually used SSH and the release push kept failing identically. Disabling persist-credentials and adding a global insteadOf rewrite for every https://github.com/ URL makes semantic-release's hardcoded push go out over SSH, where GitHub attributes it to the deploy key and the ruleset's DeployKey bypass actually applies.
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
🎉 This PR is included in version 2.11.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #9. That PR wired a deploy key into the release job via actions/checkout's ssh-key input, but the release push failed identically afterward -- confirmed from the job log that no SSH transport was actually used. ssh-key only sets core.sshCommand for checkout's own operations; it doesn't rewrite the origin remote or any later push URL, and @semantic-release/git builds its push against a plain https://github.com/... URL. persist-credentials left the default GITHUB_TOKEN's HTTP auth header active, so that's what satisfied (and got rejected by) the push, never the deploy key.
This disables persist-credentials and adds a global git config url.insteadOf rewrite for https://github.com/, so semantic-release's hardcoded push URL actually goes out over SSH and GitHub attributes it to the deploy key.