[feature]: Re-enable strict username validation#345
Merged
adrianq merged 2 commits intodevelopmentfrom May 4, 2026
Merged
Conversation
BundleMonNo change in files bundle size Groups updated (1)
Final result: ✅ View report in BundleMon website ➡️ |
Member
deeonwuli
changed the title
MiquelAdell
approved these changes
Apr 27, 2026
eperedo
approved these changes
Apr 27, 2026
Contributor
eperedo
left a comment
eperedo
left a comment
There was a problem hiding this comment.
Looks good. thanks @deeonwuli. Just a small note: DHIS2 API allows usernames that start with a dot:
so those existing users will not be editable in our application.
I think this is pretty unlikely, but just as a note in case we face that problem in the future (I've tested on WIDP and MSF and none of the users starts with an invalid character)
Member
|
@deeonwuli Do you think you can take care of @eperedo request? No rush... |
Member
|
@deeonwuli After talking to @MiquelAdell we are merging this PR so it makes it into the next release. Feel free to take care of the pending issue in another PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📌 References
📝 Implementation
/, etc.) are rejected before reaching DHIS2, fixing the downstream Android SDK login failure.📹 Screenshots/Screen capture
Screen.Recording.2026-04-21.at.10.43.33.mov
🔥 Testing
#869cyeajx