Created Team360SubSystemBase/ Renamed subsystems#49
Open
Rocksiana wants to merge 2 commits into
Open
Conversation
Created base added log prefix
Rocksiana
requested review from
JRTaylord,
Kaleb-Robotics,
RaineyRubin and
annashimshock
October 29, 2025 23:33
JRTaylord
requested changes
Oct 30, 2025
JRTaylord
left a comment
JRTaylord
left a comment
Contributor
There was a problem hiding this comment.
I've looked over your changes and I'm not seeing a few things
processInputs() call to the funnel's periodic method
Not all of the subsystems have their logging prefix updated to the method (also includes processInputs methods)
Haven't cleared out commented out logging code
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Created base added log prefix