chore(renovate): cap js-yaml below v5 while front-matter is an Analog peer - #351
Conversation
There was a problem hiding this comment.
JSON parses, the rule is well formed, exact-matches js-yaml only, and sits where no later rule clobbers allowedVersions. One blocking question inline about whether the cap survives the vulnerability-alert path it is meant to stop.
Nit: this caps js-yaml for every npm repo in the org to fix three Analog sites. Any other repo that takes a direct js-yaml dependency is silently stuck on 4.x with nothing surfacing why, and the "lift this when Analog drops front-matter" note has no reminder attached to it. matchRepositories on this rule, listing the three Cloud repos, keeps the blast radius on the repos that actually have the broken peer. Not listing the exact names as a suggestion block since those repos are not visible from here.
There was a problem hiding this comment.
4597246 fixes the v4 gap and the depType scoping is the better shape: pnpm-workspace.overrides is the real extractor string, and holding the override entries on 3.x while direct js-yaml deps move freely resolves the blast-radius tradeoff properly rather than trading one break for another.
One blocking finding inline on the new matchDepTypes list: pnpm.overrides (the package.json spelling for pnpm) is a distinct depType from overrides and isn't listed, so the fallback you described in the last round isn't actually covered.
There was a problem hiding this comment.
16dfa3e closes the last blocking finding (one line, pnpm.overrides added to matchDepTypes, nothing else touched). All three findings from the earlier rounds are resolved, JSON still parses and the rule still sits where no later rule overwrites allowedVersions. Approving.
Nit: the PR title still says "cap js-yaml below v5"; the rule is <4. Worth fixing in the squash message so the commit on main matches what it does.
Renovate opened the same js-yaml v5 PR on FerrTrack-Cloud, FerrVault-Cloud and FerrFleet-Cloud. All three break the site build:
@analogjs/contentrequiresfront-matter: ^4.0.2as a peer, and that package pinsjs-yaml ^3.13.1. GHSA-2883-xcg3-v3hh is patched on each line (3.15.2, 4.3.2), so the trees are already remediated and there is nothing v5 buys. v5 also has GHSA-pm4m-ph32-ghv5 open below 5.2.2.The three PRs are closed; this stops them coming back.