chore(renovate): let FerrLabs charts through without the one-day wait - #354
Conversation
There was a problem hiding this comment.
Rule placement is right: it sits after the generic Flux/Helm rule so the later minimumReleaseAge: "0" wins, and before the major rule so majors keep automerge: false. ghcr.io/ferrlabs/charts/** matches the packageName the flux/helmv3 managers build for an OCI HelmRepository (<registry path>/<chart>), and the glob-with-slashes form already works in this file for FerrLabs/**. One nit inline about majors joining the group.
| "matchPackageNames": [ | ||
| "ghcr.io/ferrlabs/charts/**" | ||
| ], |
There was a problem hiding this comment.
Nit: no matchUpdateTypes, so majors match this rule too and get pulled into the FerrLabs charts group. Grouping ignores the major/minor split (that is why group:allNonMajor exists), so a chart major landing in the group takes the whole branch with it: generateBranchConfig sets the branch automerge to false as soon as one upgrade in it has automerge: false, which the last rule does for majors. Net effect is the patch/minor bumps this PR is meant to fast-track stop auto-merging until someone deals with the major.
Restricting the rule keeps the major out: it then falls through to the global 1-day age with automerge: false from the last rule, i.e. an ungrouped manual PR, which is what "majors stay manual" reads as.
| "matchPackageNames": [ | |
| "ghcr.io/ferrlabs/charts/**" | |
| ], | |
| "matchPackageNames": [ | |
| "ghcr.io/ferrlabs/charts/**" | |
| ], | |
| "matchUpdateTypes": [ | |
| "patch", | |
| "minor" | |
| ], |
Same shape as the existing @ferrlabs/ and ferrlabs-* rules, so if you would rather keep all four consistent, leaving it is defensible.
Summary
oci://ghcr.io/ferrlabs/charts) now skip the one-day quarantine that the generic Flux/Helm rule applies, exactly like the@ferrlabs/npm packages, theferrlabs-*crates and theFerrLabs/.githubactions already do.matchPackageNamestargets the full OCI name because the flux manager resolves a HelmRelease backed by atype: ociHelmRepository through the docker datasource, unlike a plain HTTP repository which yields the chart name alone.Scope
This is a shared preset, so it applies to every repo that extends it. In practice that means any FerrLabs-published chart consumed by FerrLabs/Infra: RoxyCloud today, and also ferrvault-operator and lfsx. Their patch and minor chart bumps will now be raised and auto-merged as soon as they are published. Say so and I will narrow the rule to a chart list instead.
Test plan
default.jsonstill parses, and the diff is 20 added lines with no reformatting