And traits: Regeneration compromised, superior, and enhanced.

[Eagle0600]

About the PR

Adds three traits, which enhance or reduce passive healing.

Why / Balance

To further the push for custom species (rather than every pet species needing to be added individually), I'm adding these traits. As regards balance, the enhanced regeneration trait only matches slime people's regeneration, and is unlikely to significantly affect the outcome of any conflicts.

Since the comparison has already come up, and were always inevitable, here's a direct comparison to platelets of old.

	Baseline	Enhanced Regeneration	Superior Regeneration	Platelets of old
Cost	0	4?	8?	10
Maximum damage	20	65	65	400
Works when crit	No	No	No	Yes
Refills blood	—	—	—	0.025
Brute (group)	0.07	0.14	0.21	0.30
Heat	0.07	0.14	0.14	0.075
Cold, Shock, Caustic	—	—	—	0.075
Airloss (group, including bloodloss damage and while crit)	—	—	—	0.25
Poison	—	—	0.07	0.15
Radiation	—	—	—	0.15
Genetic (!)	—	—	—	0.20

As you can see, Platelets was problematic in key ways that are completely absent from these traits, including allowing someone to completely heal and get up after going crit, due to a combination of blood regeneration, airloss healing, a damage cap of 400, and working while crit.

Technical details

Media

Click to show

Requirements

• I have tested all added content and changes.
• I have added media to this PR or it does not require an ingame showcase.

Licensing:

• I confirm that I am the creator of the content in this PR, and allow licensing it under the following license(s), or that the original author has given me permission to do so:
  • AGPL (https://github.com/Floof-Station/Panta-Rhei/blob/master/LICENSE-AGPLv3.txt)
  • MIT (https://github.com/Floof-Station/Panta-Rhei/blob/master/LICENSE-MIT.txt)

Breaking changes

None

Changelog
🆑

• add: Three new traits that increase or decrease your natural regeneration.

[M3739]

Please restrict IPCs from taking these traits.

Otherwise, everything else seems to look fine on my end.

[Eagle0600]

Please restrict IPCs from taking these traits.

Otherwise, everything else seems to look fine on my end.

I'm happy to do that, but before I do, would you prefer I make the condition that the character already has a PassiveDamage component?

[M3739]

I'm happy to do that, but before I do, would you prefer I make the condition that the character already has a PassiveDamage component?

Please if you can, it'll provide some future-proofing.

[Eagle0600]

I'm happy to do that, but before I do, would you prefer I make the condition that the character already has a PassiveDamage component?

Please if you can, it'll provide some future-proofing.

I can, but I suspect (and am currently testing) that it won't tell you the trait is incompatible until you load into the game, like the how the trait Marked for Death is incompatible only if you're command. If this is the case, how does that affect your decision?

[M3739]

I'm happy to do that, but before I do, would you prefer I make the condition that the character already has a PassiveDamage component?

Please if you can, it'll provide some future-proofing.

I can, but I suspect (and am currently testing) that it won't tell you the trait is incompatible until you load into the game, like the how the trait Marked for Death is incompatible only if you're command. If this is the case, how does that affect your decision?

If that's the case, then I do prefer just blacklisting IPCs for now. It'd be frustrating to spend time working on a character only to find out a trait that can be applied to you, just gets removed on spawn.

It saves the player the trouble in that regard.

[Eagle0600]

I'm happy to do that, but before I do, would you prefer I make the condition that the character already has a PassiveDamage component?

Please if you can, it'll provide some future-proofing.

I can, but I suspect (and am currently testing) that it won't tell you the trait is incompatible until you load into the game, like the how the trait Marked for Death is incompatible only if you're command. If this is the case, how does that affect your decision?

If that's the case, then I do prefer just blacklisting IPCs for now. It'd be frustrating to spend time working on a character only to find out a trait that can be applied to you, just gets removed on spawn.

It saves the player the trouble in that regard.

Never mind, we're blacklisting IPCs. They do have the PassiveDamage component to regenerate ion damage, which means the condition doesn't even help.

[Eagle0600]

Gonna go for a walk, I'll probably be back in an hour or so.

[M3739]

LGTM!

[SyaoranFox]

There are concerns with this becoming a "must have" for combat roles. It is free healing without any downsides associated with it. What we saw with the healing that was removed, 80% of combat participants were taking it. This will require some discussion.

[Eagle0600]

There are concerns with this becoming a "must have" for combat roles. It is free healing without any downsides associated with it. What we saw with the healing that was removed, 80% of combat participants were taking it. This will require some discussion.

I have placed the comparison with Platelets in the PR for your perusal. In my opinion, the Platelets trait was both qualitatively and quantitatively an entirely different beast, and I hope that will be apparent.

[github-actions]

RSI Diff Bot; head commit 71bd5b3 merging into 95e11e8
This PR makes changes to 1 or more RSIs. Here is a summary of all changes:

Resources/Textures/_ADT/Mobs/Customization/Reptilian/reptilian_ears.rsi

State	Old	New	Status
lovelox_primary			Modified
lovelox_secondary			Modified
lovelox_tertiary			Modified

Edit: diff updated after 71bd5b3

[github-actions]

This pull request has conflicts, please resolve those before we can evaluate the pull request.

[Eagle0600]

GRRRRRRR. Ended up including more files in my merge than I needed and now it's gonna conflict every update. I'm going to reset the branch and re-do the PR.

[Eagle0600]

Later

[Eagle0600]

Closing to reset the pull request, see #679