Stabilize piecewise-constant weight normalization - #4295
Closed
FlorianPfaff wants to merge 17 commits into
Closed
Conversation
Contributor
✅MegaLinter analysis: Success
Notices📣 MegaLinter 9.5.0 is out! Discover the new features and security recommendations in the release announcement. (Skip this info by defining See detailed reports in MegaLinter artifacts Your project could benefit from a custom flavor, which would allow you to run only the linters you need, and thus improve runtime performances. (Skip this info by defining
|
FlorianPfaff
force-pushed
the
agent/stabilize-piecewise-constant-weight-normalization-20260713
branch
from
July 13, 2026 16:30
8dd98d8 to
f975f41
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Summary
Bug
PiecewiseConstantDistribution.__init__()normalized weights throughA vector can contain valid, nonnegative, individually finite weights whose mean overflows during accumulation. For example,
[finfo.max, finfo.max / 2]has a well-defined 2:1 ratio, but the direct mean becomes infinity on NumPy. Dividing by that value collapses both density weights to zero, so the resulting object is not a normalized probability density.Fix
Divide all weights by their largest entry before computing the mean. The scaled values lie in
[0, 1], so the mean remains finite while the relative weights are unchanged. The final density is mathematically identical for ordinary inputs.Validation
[0.0, 0.0][2 / (3π), 1 / (3π)]python -m py_compilemainand zero behindThe full multi-backend test matrix is delegated to GitHub Actions.