Skip to content

Stabilize piecewise-constant weight normalization - #4295

Closed
FlorianPfaff wants to merge 17 commits into
mainfrom
agent/stabilize-piecewise-constant-weight-normalization-20260713
Closed

Stabilize piecewise-constant weight normalization#4295
FlorianPfaff wants to merge 17 commits into
mainfrom
agent/stabilize-piecewise-constant-weight-normalization-20260713

Conversation

@FlorianPfaff

Copy link
Copy Markdown
Owner

Summary

  • normalize piecewise-constant weights after scaling by their largest finite entry
  • prevent overflow when individually finite weights have a non-finite arithmetic mean
  • preserve the relative weight ratios and unit-integral density
  • add a focused regression using the active backend's maximum finite floating-point value

Bug

PiecewiseConstantDistribution.__init__() normalized weights through

mean_weight = mean(w)
self.w = w / (mean_weight * 2.0 * pi)

A vector can contain valid, nonnegative, individually finite weights whose mean overflows during accumulation. For example, [finfo.max, finfo.max / 2] has a well-defined 2:1 ratio, but the direct mean becomes infinity on NumPy. Dividing by that value collapses both density weights to zero, so the resulting object is not a normalized probability density.

Fix

Divide all weights by their largest entry before computing the mean. The scaled values lie in [0, 1], so the mean remains finite while the relative weights are unchanged. The final density is mathematically identical for ordinary inputs.

Validation

  • isolated pre-fix reproduction returns [0.0, 0.0]
  • isolated corrected calculation returns [2 / (3π), 1 / (3π)]
  • regression verifies both the expected 2:1 density ratio and unit integral
  • modified source and regression modules pass python -m py_compile
  • branch is two commits ahead of current main and zero behind
  • final diff is 8 changed production lines plus one 21-line regression

The full multi-backend test matrix is delegated to GitHub Actions.

@github-actions

github-actions Bot commented Jul 13, 2026

Copy link
Copy Markdown
Contributor

MegaLinter analysis: Success

Descriptor Linter Files Fixed Errors Warnings Elapsed time
✅ COPYPASTE jscpd yes no no 20.08s
✅ JSON prettier 7 0 0 0 0.85s
✅ JSON v8r 7 0 0 3.87s
✅ MARKDOWN markdownlint 68 0 0 0 1.58s
✅ MARKDOWN markdown-table-formatter 68 0 0 0 0.67s
✅ PYTHON black 1490 182 0 0 78.6s
✅ PYTHON isort 1490 328 0 0 2.08s
✅ REPOSITORY betterleaks yes no no 1.64s
✅ REPOSITORY checkov yes no no 47.34s
✅ REPOSITORY gitleaks yes no no 13.29s
✅ REPOSITORY git_diff yes no no 0.24s
✅ REPOSITORY secretlint yes no no 48.91s
✅ REPOSITORY syft yes no no 4.87s
✅ REPOSITORY trivy-sbom yes no no 5.18s
✅ REPOSITORY trufflehog yes no no 29.9s
✅ YAML prettier 11 0 0 0 0.65s
✅ YAML v8r 11 0 0 10.55s
✅ YAML yamllint 11 0 0 0.54s

Notices

📣 MegaLinter 9.5.0 is out! Discover the new features and security recommendations in the release announcement. (Skip this info by defining SECURITY_SUGGESTIONS: false)

See detailed reports in MegaLinter artifacts

Your project could benefit from a custom flavor, which would allow you to run only the linters you need, and thus improve runtime performances. (Skip this info by defining FLAVOR_SUGGESTIONS: false)

  • Documentation: Custom Flavors
  • Command: npx mega-linter-runner@9.6.0 --custom-flavor-setup --custom-flavor-linters PYTHON_BLACK,PYTHON_ISORT,COPYPASTE_JSCPD,JSON_V8R,JSON_PRETTIER,MARKDOWN_MARKDOWNLINT,MARKDOWN_MARKDOWN_TABLE_FORMATTER,REPOSITORY_CHECKOV,REPOSITORY_GIT_DIFF,REPOSITORY_GITLEAKS,REPOSITORY_BETTERLEAKS,REPOSITORY_SECRETLINT,REPOSITORY_SYFT,REPOSITORY_TRIVY_SBOM,REPOSITORY_TRUFFLEHOG,YAML_PRETTIER,YAML_YAMLLINT,YAML_V8R

MegaLinter is graciously provided by OX Security
Show us your support by starring ⭐ the repository

@FlorianPfaff
FlorianPfaff force-pushed the agent/stabilize-piecewise-constant-weight-normalization-20260713 branch from 8dd98d8 to f975f41 Compare July 13, 2026 16:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant