Skip to content

Reject non-boolean point-set reflection flags - #5452

Merged
FlorianPfaff merged 2 commits into
mainfrom
fix/registration-reflection-flag-validation
Aug 28, 2026
Merged

Reject non-boolean point-set reflection flags#5452
FlorianPfaff merged 2 commits into
mainfrom
fix/registration-reflection-flag-validation

Conversation

@FlorianPfaff

Copy link
Copy Markdown
Owner

Summary

  • validate allow_reflection as a real boolean in point-set transform estimation
  • validate the same flag at the joint registration entry point so invalid values fail before the iterative loop
  • accept Python and NumPy booleans while rejecting truthy strings, integers, and None

Bug fixed

Previously, allow_reflection="False" was truthy. For rigid registration this could silently enable improper transforms (determinant -1) even though the supplied value reads as false.

Tests

  • regression coverage for invalid non-boolean values in estimate_transform
  • wrapper-level regression for joint_registration_assignment
  • confirms np.bool_(True) still enables a reflected rigid fit

@github-actions

Copy link
Copy Markdown
Contributor

MegaLinter analysis: Success

Descriptor Linter Files Fixed Errors Max errors Warnings Elapsed time
✅ COPYPASTE jscpd yes no no 7.91s
✅ JSON prettier 7 0 0 0 0.68s
✅ JSON v8r 7 0 0 3.6s
✅ MARKDOWN markdownlint 68 0 0 0 2.42s
✅ MARKDOWN markdown-table-formatter 68 0 0 0 0.41s
✅ PYTHON black 2032 0 0 0 67.4s
✅ PYTHON isort 2032 2 0 0 3.02s
✅ REPOSITORY betterleaks yes no no 1.52s
✅ REPOSITORY checkov yes no no 34.94s
✅ REPOSITORY git_diff yes no no 0.25s
✅ REPOSITORY secretlint yes no no 110.25s
✅ REPOSITORY syft yes no no 2.88s
✅ REPOSITORY trivy-sbom yes no no 2.93s
✅ YAML prettier 11 0 0 0 0.96s
✅ YAML v8r 11 0 0 17.03s
✅ YAML yamllint 11 0 0 0.85s

Notices

⚠️ Your configuration references items that have been removed from MegaLinter and are ignored: MAKEFILE_CHECKMAKE. See Removed linters to find their replacements.

See detailed reports in MegaLinter artifacts

Your project could benefit from a custom flavor, which would allow you to run only the linters you need, and thus improve runtime performances. (Skip this info by defining FLAVOR_SUGGESTIONS: false)

  • Documentation: Custom Flavors
  • Command: npx mega-linter-runner@10.0.0 --custom-flavor-setup --custom-flavor-linters PYTHON_BLACK,PYTHON_ISORT,COPYPASTE_JSCPD,JSON_V8R,JSON_PRETTIER,MARKDOWN_MARKDOWNLINT,MARKDOWN_MARKDOWN_TABLE_FORMATTER,REPOSITORY_CHECKOV,REPOSITORY_GIT_DIFF,REPOSITORY_BETTERLEAKS,REPOSITORY_SECRETLINT,REPOSITORY_SYFT,REPOSITORY_TRIVY_SBOM,YAML_PRETTIER,YAML_YAMLLINT,YAML_V8R

MegaLinter is provided by OX Security
Show us your support by starring ⭐ the repository

@FlorianPfaff
FlorianPfaff enabled auto-merge (squash) August 28, 2026 13:00
@FlorianPfaff
FlorianPfaff merged commit cf71974 into main Aug 28, 2026
26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant