[OPE-167] Fix Slack reaction handler: refresh card and post confirmation after ack/resolve#99
Merged
Merged
Conversation
…n ack/resolve When ✅ or 🔴 reactions were added to the incident card, the status was updated in the DB and timeline, but the Slack card stayed stale and no team-visible confirmation was posted. Mirrors the behaviour of the button handler: re-fetches the updated incident, calls refreshIncidentCard, and posts a public "<@user> acknowledged/resolved INC-N via reaction" message. Also adds a missing early return on UpdateIncidentStatus error so the confirmation path is not reached when the update fails.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
<@user> acknowledged/resolved INC-N via reactionmessage so the team sees who acted — mirrors the existing button handler behaviourreturnin the error path so the confirmation isn't posted when the DB update failsRoot cause
handleReactionAddedcalledUpdateIncidentStatusthen did nothing after — no card refresh, no channel message. The button handler (handleStatusButton) did both. This brings reactions into parity.Test plan