fix: close log file handle and log schema query failures#64
Merged
Conversation
Member
Author
|
LGTM - Good fixes for resource leak and error handling. Deferred logFile.Close() prevents fd leak. Warning log for schema query failures improves debuggability. |
1. main.go: Close logFile handle when server exits to prevent file descriptor leak during long-running stdio mode sessions. 2. dbtools.go: Log error when basic schema query fails instead of silently returning empty result, making debugging easier. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
linhdmn
force-pushed
the
fix+resource-leak
branch
from
384b4e6 to
7ac58e4
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Changes
cmd/server/main.go: Added deferred close of logFile when opened for stdio server loggingpkg/dbtools/dbtools.go: Added warning log when schema query failsTest plan
go build ./...passesgolangci-lint runpasses🤖 Generated with Claude Code