Skip to content

fix: close log file handle and log schema query failures #64

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
linhdmn merged 1 commit into from
Apr 19, 2026
Merged

fix: close log file handle and log schema query failures #64

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions cmd/server/main.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -304,6 +304,11 @@ func main() {
} else {
// Redirect all standard logging to the file
log.SetOutput(logFile)
defer func() {
if closeErr := logFile.Close(); closeErr != nil {
fmt.Fprintf(os.Stderr, "Failed to close log file: %v\n", closeErr)
}
}()
}

// Critical: Use ServeStdio WITHOUT any console output to stdout
Expand Down
3 changes: 2 additions & 1 deletion pkg/dbtools/dbtools.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1072,7 +1072,8 @@ func getBasicSchemaInfo(ctx context.Context, db db.Database, dbID, dbType string

rows, err := db.Query(ctx, query)
if err != nil {
// Return empty schema if query fails
// Log the error but return empty schema to avoid breaking the tool
logger.Warn("Failed to get basic schema for database %s: %v", dbID, err)
return result
}
defer func() {
Expand Down
Loading