feat(website): allow restricting which fields are allowed to be referenced in the AdvancedQueryFilter#1195
Open
fhennig wants to merge 5 commits into
Open
feat(website): allow restricting which fields are allowed to be referenced in the AdvancedQueryFilter#1195fhennig wants to merge 5 commits into
fhennig wants to merge 5 commits into
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Required by verbatimModuleSyntax. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
…yFilter Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Open
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
resolves #1157, #1194
Summary
Adds an optional
allowedFieldsconfig to theadvancedQuerybaseline filter. When set, the parsed LAPIS expression is walked client-side after successful validation, and any metadata column not in the allowed list causes an error with an informative message. Mutation-only queries (e.g.A123T) always pass regardless ofallowedFields, since they reference sequence positions rather than metadata columns.AdvancedQueryFilterConfigtype exported fromBaselineSelector.tsxwith optionalallowedFields?: string[]AdvancedQueryFiltercomponent accepts and enforcesallowedFieldsin itsonSuccesshandler viaextractMetadataFieldsextractMetadataFieldsutility insiloFilterExpression.tsrecursively collects allcolumnvalues from aSiloFilterExpressiontreeThe feature is fully opt-in: omitting
allowedFieldspreserves existing behaviour (any field is allowed).Test plan
extractMetadataFieldsunit tests insiloFilterExpression.spec.tsallowedFieldsscenarios inAdvancedQueryFilter.browser.spec.tsxallowedFields: ['host']on the COVID baseline config — queries onhostpassed, queries on other metadata fields showed the error, mutation queries passedPR Checklist