fix: remove colunas nome, ano_filiacao e ano_desfiliação de senadores_historico - #17
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Descrição
Remove as colunas
nome,ano_filiacaoeano_desfiliaçãodo bronzesenadores_historicoe propaga a mudança para os modelos e documentação que dependiam delas.Mudanças
dados_abertos_dbt/bronze/senadores_historico.sql— remove as 3 colunas doSELECT.dados_abertos_dbt/silver/parlamentares_historico.sql—sh.nomedeixou de existir; o nome do senador passa a vir des.nome_parlamentar(lookup desenadores) emchave_join_nomeenome_parlamentar. Schema de saída do modelo inalterado.dados_abertos_dbt/bronze/schema.yml— remove a documentação das 3 colunas e os testesverificacao_tipagemdeano_filiacao/ano_desfiliação, que passariam a falhar por referenciar colunas inexistentes.ano_filiacaoeano_desfiliaçãonão eram consumidas por nenhum modelo downstream —parlamentares_historicoera o único consumidor, e apenas denome.Teste
senadores_historicoeparlamentares_historico) e confirmar que os testes de tipagem do bronze passam.