List batches page#209
Conversation
|
I get redirected directly to the list-batches page, no matter what I do. |
zkwsk
left a comment
zkwsk
left a comment
There was a problem hiding this comment.
I get redirected to the list-batches page no matter what I do. Even if I'm not logged in.
|
|
||
| useEffect(() => { | ||
| if (user) history.replace('/dashboard'); | ||
| if (user) history.replace('/list-batches'); |
There was a problem hiding this comment.
Sorry, didn't realize that the list batches page comes up before so you can select which dashboard.
Currently you are redirected to this page even if you're not logged in though. That needs to be resolved.
Also the menu is completely blank. I think there should be options to log out and add batches (add batches, only provided you have authorization to see that).
There was a problem hiding this comment.
Probably involves changing the sidebar component a bit to allow for easier turning on/off options.
|
Decided together with @dpfernandes that we will not merge this before wednesday. Would like to set it up with a url structure so you can deeplink to the individual dashboards. This will also be necessary for the batch details component to know which batch to show details for. In theory we could handle it with internal state in context, but this is the kind of content you typically want to be able to deeplink to. Also, I'm not quite convinced that you should always land on this page when you sign in. If you have previously chosen a batch I think you should end on the dashboard for that batch. |
4 participants
solves #189
in progress: