Skip to content

Probe Implementation#5

Merged
THinnerichs merged 14 commits into
mainfrom
feat/probe
Mar 20, 2026
Merged

Probe Implementation#5
THinnerichs merged 14 commits into
mainfrom
feat/probe

Conversation

@ReubenJ
Copy link
Copy Markdown
Member

@ReubenJ ReubenJ commented Nov 15, 2024

Implementation of the method from "Just-in-time learning for bottom-up enumerative synthesis".

afbeelding

TODO:

  1. Init Probe top-down iterator
  2. init update function for the probabilities of the grammar
  3. write priority function that multiplies the priority function of the program and returns the most likely program
  4. update derivation_heuristic accordingly
  5. write tests
  • check that log probabilities align with the intended enumeration order
  • re-use parent's probabilities to calculate the current probability again.

Possible future work:

@ReubenJ ReubenJ added the enhancement New feature or request label Nov 15, 2024
@ReubenJ ReubenJ self-assigned this Nov 15, 2024
@THinnerichs
Copy link
Copy Markdown
Member

I added a prototypical implementation of Probe to Garden. I still have to write proper tests + docs.

@ReubenJ I am overwriting some core functions of Herb, like priority_function, rulenode_log_probability,... . Also, I am not happy with overwriting all top-down iterators and having to do the same for all possible iterator-type classes.
Maybe there is a smoother way?

@THinnerichs THinnerichs assigned THinnerichs and unassigned ReubenJ Feb 19, 2025
@THinnerichs THinnerichs marked this pull request as ready for review March 5, 2025 08:17
@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Mar 19, 2026

Codecov Report

❌ Patch coverage is 87.87879% with 8 lines in your changes missing coverage. Please review.
✅ Project coverage is 81.67%. Comparing base (c82513c) to head (26f8036).
⚠️ Report is 15 commits behind head on main.

Files with missing lines Patch % Lines
src/Probe/Probe.jl 88.88% 7 Missing ⚠️
src/frangel/method.jl 66.66% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main       #5      +/-   ##
==========================================
+ Coverage   74.62%   81.67%   +7.05%     
==========================================
  Files           2        3       +1     
  Lines          67      131      +64     
==========================================
+ Hits           50      107      +57     
- Misses         17       24       +7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

ReubenJ added 4 commits March 19, 2026 16:41
The way that we suggest people to use the garden doesn't require
exports.

`using Garden.Probe: probe` works whether `Probe` and `probe` are
exported or not.
@ReubenJ
Copy link
Copy Markdown
Member Author

ReubenJ commented Mar 19, 2026

All good on my end @THinnerichs 🤥

@ReubenJ
Copy link
Copy Markdown
Member Author

ReubenJ commented Mar 20, 2026

Ok, tests were broken because of the updates to imports/exports. Should be good now 🤞

@THinnerichs THinnerichs self-requested a review March 20, 2026 09:55
@THinnerichs THinnerichs merged commit d826258 into main Mar 20, 2026
2 checks passed
@THinnerichs THinnerichs deleted the feat/probe branch March 20, 2026 09:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants