Fix/Multiple Reply in Git Provider

[Amazing-Stardom]

This PR is for solving this issue: #35

Problem

As the main problem was with the webhook. On deleting any connector, it was not deleting the webhook that was created on initial connection.

Solution

On delete, the controller API is called.

1. Fetch all webhook details from the DB and create a delete job queue to delete the webhook in providers.
2. Delete both the webhook and integration ID present in the DB. (which is currently happening correct implementation)

[Amazing-Stardom]

Note: This is Livereview PR comments.

Severity: info

Implement Conditional Webhook Registry Updates

Overview

Introduced a SkipRegistryUpdate flag for webhook removal jobs. This flag controls updates to the webhook_registry table. Its value now depends on the specific webhook removal context.

Technical Highlights

• internal/jobqueue/jobqueue.go: Added SkipRegistryUpdate field to webhook removal job arguments and handlers.
• internal/api/connectors.go: Queues webhook removal jobs with SkipRegistryUpdate set to true during connector deletion.
• internal/api/server.go: Queues webhook removal jobs with SkipRegistryUpdate set to false when disabling manual triggers.

Impact

• Functionality: Provides granular control over webhook_registry updates during webhook removal operations.
• Risk: Incorrect SkipRegistryUpdate usage may lead to webhook_registry data inconsistencies.

[Amazing-Stardom]

Severity: critical

Crucial security check: ensures a user can only delete connectors they own.

Suggestions:

1. Verify validateConnectorOwnership covers all necessary authorization checks.

[LinceMathew]

what is this new type?

[Amazing-Stardom]

The webhook delete queue function had a DB update dependency.

1. Delete webhook from provider
2. Update webhook_registry table data.

Proposed API for Deleting Git Connector Have this.

1. Get webhook from the DB and then create job to delete it.
   

   LiveReview/internal/api/connectors.go

   Line 494 in c8725f3

   if err := s.jobQueue.QueueWebhookRemovalJob(ctx, id, projectPath, provider, providerURL, patToken, true); err != nil {

2. Delete the integration token.

   LiveReview/internal/api/connectors.go

   Line 501 in c8725f3

   result, err := s.db.Exec(`

   
   As it webhook_registry is a child table, it will be also deleted.
3. Return response to UI

So, as I don't want to update webhook_registrythe table, I will skip it.

let me know if the variable name needs update.

[LinceMathew]

The variable name SkipRegistryUpdate is clear and accurately reflects its purpose. It's a good choice given the context you've provided about the webhook_registry table being automatically deleted when the parent integration_tokens (connector) is removed.

[LinceMathew]

okay