fix(evaluation): use labeled break to exit foreach on Allow/Deny (closes #9)#45
Open
HeyItsGilbert wants to merge 2 commits intomainfrom
Open
fix(evaluation): use labeled break to exit foreach on Allow/Deny (closes #9)#45HeyItsGilbert wants to merge 2 commits intomainfrom
HeyItsGilbert wants to merge 2 commits intomainfrom
Conversation
#9) break inside switch only exits the switch block, not the enclosing foreach. Added :ruleLoop label to the foreach and changed break to break ruleLoop in the Allow and Deny cases so evaluation stops after the first terminal rule. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Test Results 3 files 240 suites 6s ⏱️ Results for commit 8de3b92. ♻️ This comment has been updated with latest results. |
Signed-off-by: Gilbert Sanchez <me@gilbertsanchez.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
breakinside aswitchexits theswitch, not the enclosingforeachloopAlloworDenyrule matched, evaluation continued processing subsequent rules instead of stopping:ruleLooplabel to theforeachand changed barebreaktobreak ruleLoopin theAllowandDenycasesTest plan
Test-FeatureFlagtests pass (257 tests, 0 failures)Allows when rule matches with Allow effectverifiesInvoke-Loggingcalled exactly once, confirming no extra rules are processedGenerated with Claude Code