Skip to content

fix(evaluation): use labeled break to exit foreach on Allow/Deny (closes #9) #45

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
HeyItsGilbert merged 2 commits into from
May 9, 2026
+3 −3
Merged

fix(evaluation): use labeled break to exit foreach on Allow/Deny (closes #9) #45

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
420ac8a
fix(evaluation): use labeled break to exit foreach on Allow/Deny (clo…
HeyItsGilbert May 7, 2026
8de3b92
Delete trackers/p0-bugs-tracker.jsonl
HeyItsGilbert May 7, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions Gatekeeper/Public/Test-FeatureFlag.ps1
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@
process {
# Process each feature
Write-Verbose "Processing Feature $($FeatureFlag.Name) with ($($FeatureFlag.Rules.Count)) rules"
foreach ($rule in $FeatureFlag.Rules) {
:ruleLoop foreach ($rule in $FeatureFlag.Rules) {
Write-Verbose "Processing Rule $($rule.Name)"
$testConditionSplat = @{
Context = $Context
Expand All @@ -58,12 +58,12 @@
'Allow' {
Invoke-Logging -Effect 'Allow' -Rule $rule
$finalResult = $true
break
break ruleLoop
}
'Deny' {
Invoke-Logging -Effect 'Deny' -Rule $rule
$finalResult = $false
break
break ruleLoop
}
'Audit' {
Invoke-Logging -Effect 'Audit' -Rule $rule
Expand Down
Loading