ld/add Jensen and TurbOPark wake models#29
Conversation
iupfal
left a comment
iupfal
left a comment
There was a problem hiding this comment.
Great work overall! The code is clear, neat and consistent with the package overall. I added a few minor comments to address. Also, if you could either add your verification plots to the pull request or just send them in a slack group with Kirby, Skylar and I that would be great.
There was a problem hiding this comment.
Add "JensenWakeModel, TurbOParkWakeModel" to the "from mitwindfarm import..." line
|
|
||
| return _gaussian * np.nan_to_num(WATI) | ||
|
|
||
| # [***FLAG***] Is this same model by Niayifar and Porte Agel applicable for TurbOPark? |
There was a problem hiding this comment.
Is this the wake-added turbulence model you used for your verification with the paper? Ideally, we should use exactly the same equations used in the original paper to model wake added TI.
| def __call__(self, base_windfield: Windfield, wakes: list[Wake]) -> Windfield: | ||
| return Superimposed(base_windfield, wakes, method="dominant") | ||
|
|
||
| class NQuadratic(Superposition): |
There was a problem hiding this comment.
Maybe we could use "NiayifarQuadratic" just to make the name more clear? Up to you, just an idea!
2 participants
If you want more details on best practices, please see the following guide on the Howland Lab Google Drive.
Happy merging!
This adds the Jensen (Jensen 1983), Gaussian TurbOPark (Pedersen 2022), and top-hat TurbOPark (Nygaard 2020) wake models. The outputs of these models have been validated against results from NREL's FLORIS package and from Stieren and Stevens 2016.
I'm not sure what the best approach for adding tests of wake models would be (validation plots?), so I'd love to hear any feedback!